Address Copilot review: 7 telemetry fixes

- Remove unused imports in test_telemetry.py (time, Mock)
- Use env vars for org URL/tenant ID in telemetry_demo.py
- Normalize None header values to empty string in _odata.py
- Include network exceptions (error is not None) in error count metric
- Scope _operation_scope per page fetch, not across yield points
- Dispatch on_request_error hook for network exceptions
- Update SKILL.md docs to match on_request_error behavior

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: tpellissier

examples/telemetry_demo.py

@@ -77,14 +77,16 @@
 # Dataverse SDK Setup
 # =============================================================================
 
+import os
+
 from PowerPlatform.Dataverse.client import DataverseClient
 from PowerPlatform.Dataverse.core.config import DataverseConfig
 from PowerPlatform.Dataverse.core.telemetry import TelemetryConfig, TelemetryHook
 from azure.identity import InteractiveBrowserCredential
 
-# Org details
-ORG_URL = "https://aurorabapenvcc726.crmtest.dynamics.com"
-TENANT_ID = "91bee3d9-0c15-4f17-8624-c92bb8b36ead"
+# Org details -- set via environment variables
+ORG_URL = os.environ.get("DATAVERSE_URL", "https://YOUR_ORG.crm.dynamics.com")
+TENANT_ID = os.environ.get("AZURE_TENANT_ID", "")
 
 
 class DemoTelemetryHook(TelemetryHook):

src/PowerPlatform/Dataverse/claude_skill/dataverse-sdk-use/SKILL.md

@@ -324,7 +324,7 @@ The SDK supports opt-in telemetry via hooks, OpenTelemetry, and Python logging:
 from PowerPlatform.Dataverse.core.telemetry import TelemetryConfig, TelemetryHook
 from PowerPlatform.Dataverse.core.config import DataverseConfig
 
-# Custom hook -- receives on_request_start, on_request_end, on_request_error
+# Custom hook -- receives on_request_start, on_request_end, and on_request_error
 class MyHook(TelemetryHook):
     def on_request_end(self, request, response):
         print(f"{request.operation} -> {response.status_code} in {response.duration_ms:.0f}ms")

src/PowerPlatform/Dataverse/core/telemetry.py

@@ -413,7 +413,7 @@ def record_response(
                 self._request_duration.record(duration_ms, attrs)
                 self._request_count.add(1, attrs)
 
-                if status_code >= 400:
+                if status_code >= 400 or error is not None:
                     self._error_count.add(1, attrs)
 
                 if retry_count > 0:
@@ -442,6 +442,8 @@ def record_response(
                 pass
 
         # 4. Hook dispatch (already per-hook exception safe)
+        if error is not None:
+            self._dispatch_request_error(ctx, error)
         self._dispatch_request_end(ctx, response)
 
     # ------------------------------------------------------------------

src/PowerPlatform/Dataverse/data/_odata.py

@@ -245,8 +245,8 @@ def _request(self, method: str, url: str, *, expected: tuple[int, ...] = _DEFAUL
             operation=operation,
             method=method.upper(),
             url=url,
-            client_request_id=request_context.headers.get("x-ms-client-request-id", ""),
-            correlation_id=request_context.headers.get("x-ms-correlation-id", ""),
+            client_request_id=request_context.headers.get("x-ms-client-request-id") or "",
+            correlation_id=request_context.headers.get("x-ms-correlation-id") or "",
             table_name=table_name,
         ) as tracked:
             try:

src/PowerPlatform/Dataverse/operations/records.py

@@ -434,17 +434,23 @@ def get(
 
         def _paged() -> Iterable[List[Record]]:
             with self._client._scoped_odata() as od:
-                with _operation_scope("records.get_multiple", table):
-                    for page in od._get_multiple(
-                        table,
-                        select=select,
-                        filter=filter,
-                        orderby=orderby,
-                        top=top,
-                        expand=expand,
-                        page_size=page_size,
-                    ):
-                        yield [Record.from_api_response(table, row) for row in page]
+                pages = od._get_multiple(
+                    table,
+                    select=select,
+                    filter=filter,
+                    orderby=orderby,
+                    top=top,
+                    expand=expand,
+                    page_size=page_size,
+                )
+                while True:
+                    with _operation_scope("records.get_multiple", table):
+                        try:
+                            page = next(pages)
+                        except StopIteration:
+                            return
+                        records_page = [Record.from_api_response(table, row) for row in page]
+                    yield records_page
 
         return _paged()
 

tests/unit/core/test_telemetry.py

@@ -4,9 +4,8 @@
 """Unit tests for the telemetry infrastructure."""
 
 import logging
-import time
 import unittest
-from unittest.mock import MagicMock, Mock, patch
+from unittest.mock import MagicMock, patch
 
 from PowerPlatform.Dataverse.core.config import DataverseConfig
 from PowerPlatform.Dataverse.core.telemetry import (