Skip to content

Commit 320a5bf

Browse files
tpellissierclaude
andcommitted
Fix black formatting in telemetry files
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6c25dc1 commit 320a5bf

2 files changed

Lines changed: 13 additions & 23 deletions

File tree

src/PowerPlatform/Dataverse/core/telemetry.py

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,7 @@ def trace_request(
334334
OTEL_ATTR_HTTP_URL: url,
335335
OTEL_ATTR_DATAVERSE_REQUEST_ID: client_request_id,
336336
OTEL_ATTR_DATAVERSE_CORRELATION_ID: correlation_id,
337-
**(
338-
{OTEL_ATTR_DATAVERSE_TABLE: table_name}
339-
if table_name
340-
else {}
341-
),
337+
**({OTEL_ATTR_DATAVERSE_TABLE: table_name} if table_name else {}),
342338
},
343339
)
344340

@@ -395,9 +391,7 @@ def record_response(
395391
service_request_id,
396392
)
397393
if error is not None or status_code >= 400:
398-
span.set_status(
399-
Status(StatusCode.ERROR, str(error) if error else f"HTTP {status_code}")
400-
)
394+
span.set_status(Status(StatusCode.ERROR, str(error) if error else f"HTTP {status_code}"))
401395
if error is not None:
402396
span.record_exception(error)
403397
else:
@@ -462,19 +456,15 @@ def _dispatch_request_start(self, ctx: RequestContext) -> None:
462456
except Exception:
463457
pass
464458

465-
def _dispatch_request_end(
466-
self, request: RequestContext, response: ResponseContext
467-
) -> None:
459+
def _dispatch_request_end(self, request: RequestContext, response: ResponseContext) -> None:
468460
for hook in self._hooks:
469461
if hasattr(hook, "on_request_end"):
470462
try:
471463
hook.on_request_end(request, response)
472464
except Exception:
473465
pass
474466

475-
def _dispatch_request_error(
476-
self, request: RequestContext, error: Exception
477-
) -> None:
467+
def _dispatch_request_error(self, request: RequestContext, error: Exception) -> None:
478468
for hook in self._hooks:
479469
if hasattr(hook, "on_request_error"):
480470
try:
@@ -543,12 +533,7 @@ def create_telemetry_manager(
543533
if config is None:
544534
return NoOpTelemetryManager()
545535

546-
has_any = (
547-
config.enable_tracing
548-
or config.enable_metrics
549-
or config.enable_logging
550-
or config.hooks
551-
)
536+
has_any = config.enable_tracing or config.enable_metrics or config.enable_logging or config.hooks
552537
if not has_any:
553538
return NoOpTelemetryManager()
554539

tests/unit/core/test_telemetry.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
_operation_scope,
2626
)
2727

28-
2928
# ============================================================================
3029
# A. TelemetryConfig tests
3130
# ============================================================================
@@ -568,11 +567,17 @@ def test_hook_headers_merged_into_request(self):
568567

569568
# Verify the custom header was included
570569
call_kwargs = client._http._request.call_args
571-
sent_headers = call_kwargs[1].get("headers", {}) if call_kwargs[1] else call_kwargs[0][2] if len(call_kwargs[0]) > 2 else {}
570+
sent_headers = (
571+
call_kwargs[1].get("headers", {})
572+
if call_kwargs[1]
573+
else call_kwargs[0][2] if len(call_kwargs[0]) > 2 else {}
574+
)
572575
# The headers should contain our custom header
573576
# Check via the actual kwargs passed to _http._request
574577
actual_kwargs = client._http._request.call_args
575-
actual_headers = actual_kwargs.kwargs.get("headers", actual_kwargs.args[2] if len(actual_kwargs.args) > 2 else {})
578+
actual_headers = actual_kwargs.kwargs.get(
579+
"headers", actual_kwargs.args[2] if len(actual_kwargs.args) > 2 else {}
580+
)
576581
self.assertIn("X-Custom-Trace", actual_headers)
577582
self.assertEqual(actual_headers["X-Custom-Trace"], "abc123")
578583

0 commit comments

Comments
 (0)