handle bad input in _logical_to_schema_name

Author: tpellissier

src/dataverse_sdk/data/odata.py

@@ -719,10 +719,20 @@ def _logical_to_schema_name(self, logical_name: str) -> str:
         # Normalize logical name first
         logical_name = self._normalize_logical_name(logical_name)
 
+        # Validate not empty after normalization
+        if not logical_name:
+            raise ValueError("logical_name cannot be empty or whitespace-only")
+        
         if "_" not in logical_name:
             # No prefix, just capitalize first letter
             return logical_name[:1].upper() + logical_name[1:]
+        
         prefix, rest = logical_name.split("_", 1)
+        
+        # Validate that rest is not empty (e.g., "new_" is invalid)
+        if not rest:
+            raise ValueError(f"logical_name '{logical_name}' has empty part after underscore (expected format: 'prefix_name')")
+        
         # Capitalize first letter of the part after prefix
         return f"{prefix}_{rest[:1].upper()}{rest[1:]}"
 

tests/unit/data/test_naming_normalization.py

@@ -645,5 +645,25 @@ def test_logical_to_schema_name_case_insensitive():
     assert c._logical_to_schema_name("Account") == "Account"
 
 
+def test_logical_to_schema_name_edge_cases():
+    """Test that _logical_to_schema_name handles edge cases correctly."""
+    c = TestableClient([])
+    
+    # Empty string should raise ValueError
+    with pytest.raises(ValueError, match="cannot be empty"):
+        c._logical_to_schema_name("")
+    
+    # Whitespace-only should raise ValueError
+    with pytest.raises(ValueError, match="cannot be empty"):
+        c._logical_to_schema_name("   ")
+    
+    # Trailing underscore with no suffix should raise ValueError
+    with pytest.raises(ValueError, match="empty part after underscore"):
+        c._logical_to_schema_name("new_")
+    
+    # Multiple underscores - only first split matters
+    assert c._logical_to_schema_name("new_sample_item") == "new_Sample_item"
+
+
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])