fix attribute fetching logicalName handling

Author: tpellissier

examples/basic/quickstart.py

@@ -561,17 +561,18 @@ def run_paging_demo(label: str, *, top: Optional[int], page_size: Optional[int])
 	created_details = column_create
 	if not all(isinstance(item, str) for item in created_details):
 		raise RuntimeError("create_column entries were not schema strings")
-	attribute_schema = created_details[0]
+	# create_columns returns logical names
 	odata_client = client._get_odata()
+	column_logical = created_details[0]
 	exists_after_create = None
 	exists_after_delete = None
 	attr_type_before = None
-	if metadata_id and attribute_schema:
+	if metadata_id and column_logical:
 		_ready_message = "Column metadata not yet available"
 		def _metadata_after_create():
 			meta = odata_client._get_attribute_metadata(
 				metadata_id,
-				attribute_schema,
+				column_logical,
 				extra_select="@odata.type,AttributeType",
 			)
 			if not meta or not meta.get("MetadataId"):
@@ -589,7 +590,8 @@ def _metadata_after_create():
 		if isinstance(raw_type, str):
 			attr_type_before = raw_type
 			lowered = raw_type.lower()
-	delete_target = attribute_schema or scratch_column
+	# For delete, we pass the logical name
+	delete_target = column_logical
 	log_call(f"client.delete_column('{logical}', '{delete_target}')")
 
 	def _delete_column():
@@ -610,12 +612,14 @@ def _delete_column():
 	deleted_details = column_delete
 	if not all(isinstance(item, str) for item in deleted_details):
 		raise RuntimeError("delete_column entries were not schema strings")
-	if attribute_schema not in deleted_details:
+	# deleted_details contains logical names (lowercase), so check for column_logical
+	if column_logical not in deleted_details:
 		raise RuntimeError("delete_column response missing expected schema name")
-	if metadata_id and attribute_schema:
+	if metadata_id and column_logical:
 		_delete_message = "Column metadata still present after delete"
 		def _ensure_removed():
-			meta = odata_client._get_attribute_metadata(metadata_id, attribute_schema)
+			# _get_attribute_metadata now accepts logical names
+			meta = odata_client._get_attribute_metadata(metadata_id, column_logical)
 			if meta:
 				raise RuntimeError(_delete_message)
 			return True

src/dataverse_sdk/data/odata.py

@@ -881,10 +881,23 @@ def _create_entity(
     def _get_attribute_metadata(
         self,
         entity_metadata_id: str,
-        schema_name: str,
+        logical_name: str,
         extra_select: Optional[str] = None,
     ) -> Optional[Dict[str, Any]]:
-        attr_escaped = self._escape_odata_quotes(schema_name)
+        """Get attribute metadata by logical name.
+        
+        Args:
+            entity_metadata_id: The MetadataId of the entity
+            logical_name: The logical name of the attribute (e.g., "new_category")
+            extra_select: Optional comma-separated list of additional fields to select
+            
+        Returns:
+            Dict with attribute metadata, or None if not found
+        """
+        # Normalize logical name for case-insensitive lookup
+        logical_name = self._normalize_logical_name(logical_name)
+        
+        attr_escaped = self._escape_odata_quotes(logical_name)
         url = f"{self.api}/EntityDefinitions({entity_metadata_id})/Attributes"
         select_fields = ["MetadataId", "LogicalName", "SchemaName"]
         if extra_select:
@@ -898,7 +911,7 @@ def _get_attribute_metadata(
                     select_fields.append(piece)
         params = {
             "$select": ",".join(select_fields),
-            "$filter": f"SchemaName eq '{attr_escaped}'",
+            "$filter": f"LogicalName eq '{attr_escaped}'",
         }
         r = self._request("get", url, params=params)
         try:
@@ -1419,9 +1432,8 @@ def _delete_columns(
         for column_name in names:
             # Normalize column name for case-insensitive handling  
             column_name_normalized = self._normalize_logical_name(column_name)
-            # Look up actual SchemaName from server for existing attribute
-            col_schema = self._get_attribute_schema_name(logical_name, column_name_normalized)
-            attr_meta = self._get_attribute_metadata(metadata_id, col_schema, extra_select="@odata.type,AttributeType")
+            # Get attribute metadata by logical name
+            attr_meta = self._get_attribute_metadata(metadata_id, column_name_normalized, extra_select="@odata.type,AttributeType")
             if not attr_meta:
                 raise MetadataError(
                     f"Column '{column_name}' not found on table '{logical_name}'.",