Skip to content

test: Address unreachable statement warnings in test cases #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kanchan-Microsoft wants to merge 1 commit into
base: dev-v4
Choose a base branch
from
+3 −3
Open

test: Address unreachable statement warnings in test cases #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/backend/common/database/test_database_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ async def get_team_agent(self, team_id, agent_name): return None
raise ValueError("Test exception")

# Even with exception, close should have been called
assert database.closed is True
assert database.closed is True # lgtm[py/unreachable-statement]


class TestDatabaseBaseInheritance:
Expand Down
4 changes: 2 additions & 2 deletions src/tests/backend/v4/config/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ async def cancel_task():
cancel_task_handle = asyncio.create_task(cancel_task())

with self.assertRaises(asyncio.CancelledError):
await task
await task # lgtm[py/statement-has-no-effect]

_ = await cancel_task_handle
self.assertTrue(task.cancelled())
Expand All @@ -365,7 +365,7 @@ async def cancel_task():
cancel_task_handle = asyncio.create_task(cancel_task())

with self.assertRaises(asyncio.CancelledError):
await task
await task # lgtm[py/statement-has-no-effect]

_ = await cancel_task_handle
self.assertTrue(task.cancelled())
Expand Down