fix: Add Pop up when Plan Approval session is end and also handle old plan…#1002
Open
NirajC-Microsoft wants to merge 4 commits into
Open
fix: Add Pop up when Plan Approval session is end and also handle old plan…#1002NirajC-Microsoft wants to merge 4 commits into
NirajC-Microsoft wants to merge 4 commits into
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces robust handling for plan approval timeouts and superseded plans, improving both backend reliability and frontend user experience. The backend now distinguishes between plans that are superseded (when a user starts a new task before approving the previous one) and plans that time out due to inaction, handling each case appropriately. On the frontend, users are presented with a clear dialog when a plan approval times out, guiding them to start a new task.
Backend: Plan approval timeout and supersession handling
src/backend/v4/config/settings.py,cancel_pending_approvals_for_user,is_plan_superseded,set_approval_pending) [1] [2].PlanSupersededErrorandPlanTimeoutErrorto clearly distinguish between a plan being superseded and a plan timing out, and refactored orchestration logic to use these exceptions for clean error propagation (src/backend/v4/orchestration/exceptions.py,src/backend/v4/orchestration/human_approval_manager.py,src/backend/v4/orchestration/orchestration_manager.py) [1] [2] [3] [4].src/backend/v4/orchestration/orchestration_manager.py).src/backend/v4/api/router.py).Frontend: User experience for plan approval timeouts
PlanTimeoutDialogReact component that is displayed when the backend signals a plan approval timeout, providing clear instructions to the user (src/App/src/components/common/PlanTimeoutDialog.tsx).PlanPagecomponent (src/App/src/store/slices/planSlice.ts,src/App/src/pages/PlanPage.tsx,src/App/src/hooks/usePlanWebSocket.tsx) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11].Other improvements
src/App/src/api/httpClient.ts).Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information