Skip to content

Conversation

@Vamshi-Microsoft
Copy link
Contributor

Purpose

This pull request updates several GitHub workflow files to improve input validation, enhance robustness, and streamline EXP configuration for deployment jobs. The main changes include making resource ID validation case-insensitive, ensuring default values for workflow inputs to prevent errors, and introducing automatic EXP enablement based on related parameters. These updates help make the workflows more reliable and easier to maintain.

Input Validation Improvements

  • Resource ID validation for AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID and AZURE_EXISTING_AI_PROJECT_RESOURCE_ID now accepts case-insensitive values, making workflows more flexible for Azure resource IDs. (.github/workflows/deploy-linux.yml, .github/workflows/deploy-windows.yml, .github/workflows/job-deploy-linux.yml, .github/workflows/job-deploy-windows.yml, .github/workflows/job-deploy.yml) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

  • Validation for QUOTA_FAILED now allows an empty string, in addition to 'true' and 'false', for greater compatibility with upstream jobs. (.github/workflows/job-send-notification.yml)

Workflow Input Defaults

  • Default values are provided for several workflow inputs (e.g., azure_location, resource_group_name, run_e2e_tests, existing_webapp_url) to prevent errors when outputs are missing. (.github/workflows/deploy-linux.yml, .github/workflows/deploy-windows.yml) [1] [2]

EXP Configuration Enhancements

  • Added a new step for auto-configuring EXP: EXP is enabled automatically if related resource IDs are provided, even if the EXP flag is not explicitly set. This logic is centralized and outputs a new EXP_ENABLED value. (.github/workflows/job-deploy.yml) [1] [2]
  • All downstream jobs now use the computed EXP_ENABLED value instead of the raw input, ensuring consistent EXP status across the workflow. (.github/workflows/job-deploy.yml) [1] [2]
  • Workflow summary now reflects the new EXP status logic, providing clearer feedback in deployment summaries. (.github/workflows/job-deploy.yml)

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants