Skip to content

Fix name for enum keys in a map holding structs #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OXINARF wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix name for enum keys in a map holding structs #1531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MIDebugEngine/Engine.Impl/Variables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private VariableInformation(TupleValue results, VariableInformation parent, stri

int index;

if (!results.Contains("value") && (Name == TypeName || Name.Contains("::")))
if (name == null && !results.Contains("value") && (Name == TypeName || Name.Contains("::")))
Copy link
Member

@WardenGnaw WardenGnaw Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will want to move the name null check with Name.Contains("::") since thats where the issue is but we still want the Name == TypeName check run. The issue is the enum Name contains ::.

Suggested change
if (name == null && !results.Contains("value") && (Name == TypeName || Name.Contains("::")))
if (!results.Contains("value") && (Name == TypeName || (Name.Contains("::") && name == null)))

{
// base classes show up with no value and exp==type
// (sometimes underlying debugger does not follow this convention, when using typedefs in templated types so look for "::" in the field name too)
Expand Down
Loading