Update to use new test data models#713
Open
skottmckay wants to merge 5 commits into
Open
Conversation
Fix test issues. Some due to new modle. Some due to not running tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates test suites and docs to align with the new shared test-data model naming and adjusts C# integration test setup/streaming handling.
Changes:
- Renames embedding test model aliases across Rust, Python, JS, and C# tests.
- Updates C# embedding expected model/value assertions and initializes test utilities via a static constructor.
- Adjusts C# streaming chat/tool tests to stop before unsupported usage responses.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
sdk/rust/tests/integration/common/mod.rs |
Updates shared Rust embedding test model alias. |
sdk/python/test/README.md |
Updates documented Whisper test variant version. |
sdk/python/test/conftest.py |
Updates shared Python embedding test model alias. |
sdk/js/test/testUtils.ts |
Updates shared JS embedding test model alias. |
sdk/js/test/openai/embeddingClient.test.ts |
Updates embedding cache assertion text. |
sdk/cs/test/FoundryLocal.Tests/Utils.cs |
Moves test utility initialization into a static constructor and trims whitespace. |
sdk/cs/test/FoundryLocal.Tests/EmbeddingClientTests.cs |
Updates C# embedding variant references and known expected value. |
sdk/cs/test/FoundryLocal.Tests/ChatCompletionsTests.cs |
Breaks streaming test loops when stop finish reason is reached. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/microsoft/Foundry-Local/sessions/d43a24ee-f636-4980-92a0-4bbe962c04b9 Co-authored-by: skottmckay <979079+skottmckay@users.noreply.github.com>
….com/microsoft/Foundry-Local into skottmckay/UpdateToNewTestDataModels
baijumeswani
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also Fix test issues.
Some due to new models.
Some due to not running tests.
The Utils init of whether test data is available doesn't seem to fire before we check the value in the 'skip if not available' attribute. Changed to use static ctor to ensure it's inited.