Skip to content

Update to use new test data models#713

Open
skottmckay wants to merge 5 commits into
mainfrom
skottmckay/UpdateToNewTestDataModels
Open

Update to use new test data models#713
skottmckay wants to merge 5 commits into
mainfrom
skottmckay/UpdateToNewTestDataModels

Conversation

@skottmckay
Copy link
Copy Markdown
Collaborator

Also Fix test issues.
Some due to new models.
Some due to not running tests.

The Utils init of whether test data is available doesn't seem to fire before we check the value in the 'skip if not available' attribute. Changed to use static ctor to ensure it's inited.

Fix test issues. Some due to new modle. Some due to not running tests.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment May 16, 2026 8:27am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test suites and docs to align with the new shared test-data model naming and adjusts C# integration test setup/streaming handling.

Changes:

  • Renames embedding test model aliases across Rust, Python, JS, and C# tests.
  • Updates C# embedding expected model/value assertions and initializes test utilities via a static constructor.
  • Adjusts C# streaming chat/tool tests to stop before unsupported usage responses.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/rust/tests/integration/common/mod.rs Updates shared Rust embedding test model alias.
sdk/python/test/README.md Updates documented Whisper test variant version.
sdk/python/test/conftest.py Updates shared Python embedding test model alias.
sdk/js/test/testUtils.ts Updates shared JS embedding test model alias.
sdk/js/test/openai/embeddingClient.test.ts Updates embedding cache assertion text.
sdk/cs/test/FoundryLocal.Tests/Utils.cs Moves test utility initialization into a static constructor and trims whitespace.
sdk/cs/test/FoundryLocal.Tests/EmbeddingClientTests.cs Updates C# embedding variant references and known expected value.
sdk/cs/test/FoundryLocal.Tests/ChatCompletionsTests.cs Breaks streaming test loops when stop finish reason is reached.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk/python/test/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants