Derive SDK package versions from Foundry Local Core#710
Open
bmehta001 wants to merge 4 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves SDK/package versioning to versions derived from Foundry Local Core NBGV output and propagates those versions through packaging artifacts and SDK build templates.
Changes:
- Computes SDK, Python, and Core package versions from the selected Core branch.
- Reads Python-safe Core wheel/dependency versions from the shared
version-infoartifact. - Updates C++ native dependency defaults to read from
sdk/deps_versions.json.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pipelines/foundry-local-packaging.yml |
Adds Core-derived version computation and removes manual version parameter plumbing. |
.pipelines/templates/package-core-steps.yml |
Uses shared Python version output for Core wheels and dependency metadata. |
.pipelines/templates/build-cs-steps.yml |
Removes unused manual version parameters. |
.pipelines/templates/build-js-steps.yml |
Removes unused manual version parameters. |
.pipelines/templates/build-python-steps.yml |
Removes unused manual version parameters. |
.pipelines/templates/build-rust-steps.yml |
Removes unused manual version parameters. |
sdk/cpp/CMakeLists.txt |
Loads native dependency versions from sdk/deps_versions.json. |
sdk/cpp/README.md |
Updates troubleshooting guidance to point at sdk/deps_versions.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-infoartifact so all SDK package formats come from the same Core version source.deps_versions*.json.sdk/deps_versions.jsoninstead of hard-coding Core/ORT package versions in CMake.Validation
sdk/deps_versions.json.bhamehta/filter-min-fl-versionCore branch for dev, release, and explicit prerelease cases.