C++ implementation of FL Core + SDK.#705
Open
skottmckay wants to merge 7 commits into
Open
Conversation
Update C# and python SDKs to use new setup.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add note about AzureModelCatalog cache-only mode
…ed copilot-cpp-review-report.md to capture. Added some format/lint setup as well.
Fix some issues from the C++ Copilot review changes. Handle no CPU Whisper models being returned by the catalog.
Fix some C# test issues and gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ implementation of FL Core + SDK.
C# and python SDKs to use new setup.
Currently in sdk_v2 for ease of comparison. Will replace sdk implementation pre-checkin.
To test locally build the c++ sdk first (sdk_v2/cpp/build.{sh|bat}.
C# and python bindings look for the default RelWithDebInfo build from that.
CI produces nuget package that can also be used for testing. Not published to a feed yet though.
Various design decisions are captured in sdk_v2/cpp/docs for reference.
The current implementation uses a static catalog listing. Will change to live catalog when possible. Easily updated if we have additional models to add.
Set the TEST_MODEL_CACHE_DIR environment variable to point to test-data-shared if you have that locally and want to avoid some model downloads.