Factor out tree identifier compression and healing utils#27367
Draft
CraigMacomber wants to merge 3 commits into
Draft
Factor out tree identifier compression and healing utils#27367CraigMacomber wants to merge 3 commits into
CraigMacomber wants to merge 3 commits into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (638 lines, 13 files), I've queued these reviewers:
How this works
|
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Factor out tree identifier compression and healing utils.
This will make it practical to remove the originator id (which is incorrect) that is passed down into some of the codecs: they can use the new helper functions to do the conversions they need without it, and will produce better errors if they do hit the bug.
Then updated formats/versions of the codecs can be added which require the originator id (and don't need these workarounds) and the distinction between these two cases will be clean.
Reviewer Guidance
The review process is outlined on this wiki page.