Skip to content

Factor out tree identifier compression and healing utils#27367

Draft
CraigMacomber wants to merge 3 commits into
microsoft:mainfrom
CraigMacomber:betterID2
Draft

Factor out tree identifier compression and healing utils#27367
CraigMacomber wants to merge 3 commits into
microsoft:mainfrom
CraigMacomber:betterID2

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

@CraigMacomber CraigMacomber commented May 20, 2026

Description

Factor out tree identifier compression and healing utils.

This will make it practical to remove the originator id (which is incorrect) that is passed down into some of the codecs: they can use the new helper functions to do the conversions they need without it, and will produce better errors if they do hit the bug.

Then updated formats/versions of the codecs can be added which require the originator id (and don't need these workarounds) and the distinction between these two cases will be clean.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (638 lines, 13 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  288859 links
    1925 destination URLs
    2175 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant