Skip to content

test(client-presence): cleanup type test generation#27363

Open
jason-ha wants to merge 1 commit into
microsoft:mainfrom
jason-ha:presence/test/cleanup-type-test-validation
Open

test(client-presence): cleanup type test generation#27363
jason-ha wants to merge 1 commit into
microsoft:mainfrom
jason-ha:presence/test/cleanup-type-test-validation

Conversation

@jason-ha
Copy link
Copy Markdown
Contributor

  • use root entrypoint (empty string - there isn't public versus beta, etc. here)
  • remove dead script entry

@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (5 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines type test generation configuration for @fluid-internal/presence-definitions by aligning it with the root entrypoint behavior supported by flub generate typetests and removing an unused script variant.

Changes:

  • Removed the unused typetests:gen-disabled script entry.
  • Updated typeValidation.entrypoint to "" to explicitly target the package’s default/root entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants