Update Components to address governance issues #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
May 8, 2025
MSNev
commented
- Update rush
- Update rush
There was a problem hiding this comment.
Pull Request Overview
This PR updates components to address governance issues by upgrading the Rush version and refactoring external module definitions in the install-run scripts.
- Updated Rush version in rush.json from "5.148.0" to "5.153.1".
- Added and reorganized external module definitions in common/scripts/install-run.js.
- Refactored and reordered external module definitions and comment phrasing in common/scripts/install-run-rush.js.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rush.json | Upgraded the Rush version to support updated governance policies. |
| common/scripts/install-run.js | Refactored external module exports and updated spread operator usage in the _copyAndTrimNpmrcFile call. |
| common/scripts/install-run-rush.js | Reorganized external module definitions and corrected comment grammar. |
Files not reviewed (1)
- common/config/rush/npm-shrinkwrap.json: Language not supported
Karlie-777
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.