fix: merging dev to main#642
Open
Priyanka-Microsoft wants to merge 6 commits into
Open
Conversation
feat: restore Document Intelligence private networking
fix: downmerge from main to dev
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Document Intelligence (Cognitive Services) deployment in the infra layer to support WAF-aligned private networking by disabling public access when enablePrivateNetworking is enabled and adding a conditional private endpoint deployment tied to the Cognitive Services private DNS zone.
Changes:
- Updated Document Intelligence
publicNetworkAccess/networkAcls.defaultActionto toggle based onenablePrivateNetworking. - Added a conditional
docIntelPrivateEndpointdeployment (AVM private-endpoint module) with DNS zone group association. - Regenerated/updated
infra/main.jsonto reflect the new Bicep changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/main.bicep | Makes Document Intelligence WAF-aligned for private networking and adds a conditional private endpoint module. |
| infra/main.json | Generated ARM template updates reflecting the new networking settings and private endpoint deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: 'pep-${docIntelAccountName}' | ||
| customNetworkInterfaceName: 'nic-${docIntelAccountName}' | ||
| location: solutionLocation | ||
| tags: tags |
feat: Enhance email template, add RG owner tag, scalability input
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
Roopan-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the networking configuration for the Document Intelligence resource in
infra/main.bicepto support private networking, and conditionally deploys a private endpoint when enabled. The changes improve security and flexibility by allowing the resource to be accessed only via private networking if desired.Networking configuration improvements:
publicNetworkAccessandnetworkAcls.defaultActionproperties for thedocumentIntelligencemodule to enable or disable public access based on theenablePrivateNetworkingparameter, aligning with WAF requirements.Private endpoint deployment:
docIntelPrivateEndpointmodule, which provisions a private endpoint and associates it with a private DNS zone when private networking is enabled.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information