fix(helm): coerce OmsAgent.isUsingAADAuth to a boolean#1679
Open
rashmichandrashekar wants to merge 2 commits into
Open
fix(helm): coerce OmsAgent.isUsingAADAuth to a boolean#1679rashmichandrashekar wants to merge 2 commits into
rashmichandrashekar wants to merge 2 commits into
Conversation
Helm --set and quoted YAML both deliver this value as a string. Any non-empty string is truthy in Go templates, so the literal string false was evaluating to true and enabling AAD-only RBAC/secret references in ama-logs.yaml. Compare the lowercased string to true to coerce it into a real boolean.
zanejohnson-azure
previously approved these changes
May 12, 2026
…s chart
Same Go-template bug as the prod-clusters chart: \ was being assigned the raw value of .Values.OmsAgent.isUsingAADAuth (or .Values.amalogs.useAADAuth for Arc), which Helm delivers as a string from quoted YAML or --set. The string "false" is non-empty, so {{ if \ }} evaluated to true and the AAD-only RBAC / secrets / deployment / hpa / service / env-var paths were rendered even when AAD was disabled.
Coerce to a real bool via (eq (lower (toString val)) "true") in all 7 affected templates: ama-logs-daemonset.yaml, ama-logs-daemonset-windows.yaml, ama-logs-deployment.yaml, ama-logs-deployment-multitenancy.yaml, ama-logs-hpa.yaml, ama-logs-rbac.yaml, ama-logs-service.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm --set and quoted YAML both deliver this value as a string. Any non-empty string is truthy in Go templates, so the literal string false was evaluating to true and enabling AAD-only RBAC/secret references in ama-logs.yaml. Compare the lowercased string to true to coerce it into a real boolean.