Change documentation link into repository link#1115
Conversation
|
@dtolnay please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Cargo package metadata across the workspace to use repository (inherited from the workspace) instead of documentation.
Changes:
- Replace
documentation(.workspace)withrepository(.workspace)in multiple crate manifests. - Update root workspace package metadata to define
repositoryinstead ofdocumentation.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Replaces workspace documentation URL with repository URL used by member crates. |
| diskann/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-wide/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-vector/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-utils/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-tools/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-quantization/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-providers/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-platform/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-linalg/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-label-filter/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-disk/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-bftree/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-benchmark/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-benchmark-simd/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-benchmark-runner/Cargo.toml | Switches inherited package metadata from documentation to repository. |
| diskann-benchmark-core/Cargo.toml | Switches inherited package metadata from documentation to repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hildebrandmw
left a comment
There was a problem hiding this comment.
Thanks! I appreciate the PR!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
- Coverage 89.46% 89.46% -0.01%
==========================================
Files 482 482
Lines 91092 91092
==========================================
- Hits 81497 81496 -1
- Misses 9595 9596 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
documentationis supposed to be API documentation (rustdoc). Settingdocumentationis blocking crates.io from linking to docs.rs for all these crates. For example https://crates.io/crates/diskann-linalg does not link to https://docs.rs/diskann-linalg.repositoryis the correct metadata key for a crate's source repository.