Skip to content

Ensure range results are sorted after the second round. #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hildebrandmw wants to merge 2 commits into
base: main
Choose a base branch
from
+155 −151
Open

Ensure range results are sorted after the second round. #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9c737
Ensure range results are sorted after the second round.
hildebrandmw May 28, 2026
2c3dec8
Fixup doc comments.
hildebrandmw May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions diskann/src/graph/search/range_search.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ where
)
.await?;

// The second round of range search does not ensure items are added to
// `in_range` in sorted order. This restores that order.
scratch.in_range.sort_unstable();

InternalSearchStats {
cmps: initial_stats.cmps,
hops: initial_stats.hops + range_stats.hops,
Expand Down
Loading
Loading