Skip to content

Add int8 data type support to diskann-garnet/vectorset#1060

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/add-int8-support-vectorset
Draft

Add int8 data type support to diskann-garnet/vectorset#1060
Copilot wants to merge 3 commits into
mainfrom
copilot/add-int8-support-vectorset

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026 •
edited
Loading

  • Examine Rust FFI changes (VectorValueType::SB8, VectorQuantType::Q8 handling)
  • Examine current Garnet C# source files from microsoft/garnet main branch
  • Generate patch instructions for Garnet C# changes
  • Commit patch file to PR branch

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request
int8 support in diskann-garnet/vectorset #1059
Open
@harsha-simhadri
Add int8 data type support to diskann-garnet and vectorset
b81465b 
- Add SB8 variant to VectorValueType for signed 8-bit input
- Handle SB8 in interpret_vector (direct storage and f32 conversion)
- Handle Q8 quant type in create_index to create index with i8 VectorRepr
- Handle FP32 + Q8 path for converting f32 input to i8 storage
- Add Int8 variant to vectorset DataType enum
- Implement Element trait for i8 and wire up dispatch
- Use SB8/Q8 protocol values in ingest and query commands
- Update README to document SB8 and Q8 extensions

Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/7664c19b-7cdd-4a84-8249-951b2e2e040b

Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot AI changed the title [WIP] Add int8 support to diskann-garnet/vectorset Add int8 data type support to diskann-garnet/vectorset May 12, 2026
Copilot AI requested a review from harsha-simhadri May 12, 2026 23:23
@harsha-simhadri
Add Garnet C# companion patch instructions for SB8/Q8 support
8339830 
Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/9adc0f60-1eec-419c-ae00-3fbc815d2e5b

Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha-simhadri harsha-simhadri Awaiting requested review from harsha-simhadri

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@harsha-simhadri harsha-simhadri

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

int8 support in diskann-garnet/vectorset

2 participants

@harsha-simhadri