[CI] Try to fix publishing step#1057
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the tag-on-main verification in the crates.io publish workflow for tag pushes in GitHub Actions by switching from local-branch inspection to a reachability check against origin/main.
Changes:
- Replace
git branch --contains ... | grep mainwithgit merge-base --is-ancestor ... origin/mainto correctly validate tag commits on CI. - Keep the existing failure behavior/message when the tag does not point to a commit reachable from
origin/main.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 461 461
Lines 85920 85920
=======================================
Hits 76912 76912
Misses 9008 9008
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harsha-simhadri
approved these changes
May 12, 2026
JordanMaples
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Verify tag is on main branch" step always fails on tag pushes because
git branch --containsonly lists local branches. In GitHub Actions,mainexists only as the remote-tracking reforigin/main, so the grep never matches. You can try this locally with a fresh clone from main and runninggit checkout v0.52.0. An example failure is hereReplaced with
git merge-base --is-ancestorwhich directly checks reachability fromorigin/mainwithout requiring a local branch.