[deps] Don't pull rayon as a dependency of diskann.#1024
Open
hildebrandmw wants to merge 1 commit intomainfrom
Open
[deps] Don't pull rayon as a dependency of diskann.#1024hildebrandmw wants to merge 1 commit intomainfrom
rayon as a dependency of diskann.#1024hildebrandmw wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes rayon from diskann’s transitive dependency set by opting out of diskann-utils default features (where rayon is enabled by default). This keeps parallelism support available in the workspace (and for crates that explicitly need it) without forcing diskann consumers to pull rayon.
Changes:
- Disable
diskann-utilsdefault features indiskann/Cargo.tomlto avoid pullingrayontransitively.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 460 460
Lines 85424 85424
=======================================
Hits 76469 76469
Misses 8955 8955
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid
rayonas a direct dependency ofdiskannby disablingdefault-featuresindiskann-utils.