Skip to content

[deps] Don't pull rayon as a dependency of diskann.#1024

Open
hildebrandmw wants to merge 1 commit intomainfrom
mhildebr/no-rayon
Open

[deps] Don't pull rayon as a dependency of diskann.#1024
hildebrandmw wants to merge 1 commit intomainfrom
mhildebr/no-rayon

Conversation

@hildebrandmw
Copy link
Copy Markdown
Contributor

Avoid rayon as a direct dependency of diskann by disabling default-features in diskann-utils.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes rayon from diskann’s transitive dependency set by opting out of diskann-utils default features (where rayon is enabled by default). This keeps parallelism support available in the workspace (and for crates that explicitly need it) without forcing diskann consumers to pull rayon.

Changes:

  • Disable diskann-utils default features in diskann/Cargo.toml to avoid pulling rayon transitively.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (95b6593) to head (56e81e6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         460      460           
  Lines       85424    85424           
=======================================
  Hits        76469    76469           
  Misses       8955     8955           
Flag Coverage Δ
miri 89.51% <ø> (ø)
unittests 89.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants