Skip to content

Make macOS CI runners opt-in via workflow_dispatch #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −2
Open

Make macOS CI runners opt-in via workflow_dispatch #1012

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b3a6ad
Make macOS CI runners opt-in via workflow_dispatch
Copilot May 4, 2026
9b2d6df
Compact macOS opt-in CI: use dynamic fromJSON matrix instead of dupli…
Copilot May 4, 2026
3e6f9d4
abridged comments
harsha-simhadri May 5, 2026
a402ca9
Potential fix for pull request finding
harsha-simhadri May 5, 2026
bb74bde
remove ternary
harsha-simhadri May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ on:
branches: ["main"]
pull_request:
branches: ["main"]
workflow_dispatch:
Copy link
Copy Markdown
Contributor

@arrayka arrayka May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just run macos after check-in (push event)?
We run miri-tests on post check-in: if: ${{ github.event_name == 'push' }}

inputs:
run_macos:
description: "Run macOS CI jobs (slow runners, opt-in)"
type: boolean
default: false
Comment thread
harsha-simhadri marked this conversation as resolved.

name: CI

Expand Down Expand Up @@ -361,17 +367,21 @@ jobs:
--package diskann-quantization \
-- --skip compile_tests

# macOS is opt-in since it is slow to provision.
# It is excluded from the default push/PR matrix, and only included for manually
# dispatched runs when `run_macos: true` is set.
test-workspace:
needs: basics
name: test workspace
if: ${{ matrix.os != 'macos-latest' || (github.event_name == 'workflow_dispatch' && inputs.run_macos) }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- ubuntu-24.04-arm
- macos-latest
- macos-latest # skipped unless manually triggered

steps:
- uses: actions/checkout@v4
Expand All @@ -397,13 +407,14 @@ jobs:
test-workspace-features:
needs: basics
name: test workspace (all features)
if: ${{ matrix.os != 'macos-latest' || (github.event_name == 'workflow_dispatch' && inputs.run_macos) }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- macos-latest
- macos-latest # skipped unless manually triggered

steps:
- uses: actions/checkout@v4
Expand Down