Fix fxc path for non-Visual Studio builds#670
Merged
walbourn merged 1 commit intomicrosoft:mainfrom Feb 13, 2026
Merged
Conversation
Member
|
Thanks for the feedback. I think the safer thing would be to make it: And the same changes should be made in: https://github.com/microsoft/DirectXTK/blob/main/CMakeLists.txt#L260 https://github.com/microsoft/DirectXTK12/blob/main/CMakeLists.txt#L295 Would you like to submit PRs for these? |
4983819 to
f83c7b5
Compare
Contributor
Author
|
Thanks for the review. I’ve reverted the removed line.
I'll send PRs later. |
This was referenced Feb 12, 2026
walbourn
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that
CMAKE_SYSTEM_VERSIONdid not have the revision number. This tiny change ensures non-Visual Studio generators (e.g. Ninja) can findfxcwithout requiring manual environment variable adjustments.