Skip to content

Fix signed/unsigned mismatch in LinAlgTests.cpp #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damyanp merged 2 commits into from
Apr 3, 2026
Merged

Fix signed/unsigned mismatch in LinAlgTests.cpp #8336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9b6aa2
Fix signed/unsigned mismatch in LinAlgTests.cpp
damyanp Apr 3, 2026
5128696
chore: autopublish 2026-04-03T19:10:36Z
github-actions[bot] Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tools/clang/unittests/HLSLExec/LinAlgTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,21 +226,22 @@ static VariantCompType makeExpected(ComponentType CompType, size_t NumElements,
switch (CompType) {
case ComponentType::F32: {
std::vector<float> Floats(NumElements);
for (int32_t I = 0; I < NumElements; I++)
for (size_t I = 0; I < NumElements; I++)
Floats[I] = StartingVal + static_cast<float>(Increment ? I : 0);
return Floats;
}
case ComponentType::I32: {
DXASSERT(StartingVal < static_cast<float>(INT_MAX),
"Value too large to cast to int32_t");
std::vector<int32_t> Ints(NumElements);
for (int32_t I = 0; I < NumElements; I++)
Ints[I] = static_cast<int32_t>(StartingVal) + (Increment ? I : 0);
for (size_t I = 0; I < NumElements; I++)
Ints[I] = static_cast<int32_t>(StartingVal) +
static_cast<int32_t>(Increment ? I : 0);
return Ints;
}
case ComponentType::F16: {
std::vector<HLSLHalf_t> Halfs(NumElements);
for (int32_t I = 0; I < NumElements; I++) {
for (size_t I = 0; I < NumElements; I++) {
// Downcasting is safe here since HLSLHalf_t will clamp if F is too large.
float F = StartingVal + static_cast<float>(Increment ? I : 0);
Halfs[I] = HLSLHalf_t(F);
Expand Down