Skip to content

[SM6.10] Update 8-bit float type name to F8_E4M3FN #8329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hekota merged 1 commit into from
Apr 3, 2026
+7 −7
Merged

[SM6.10] Update 8-bit float type name to F8_E4M3FN #8329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/dxc/DXIL/DxilConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ enum class ComponentType : uint32_t {
// BEGIN NEW FOR SM 6.9
I8 = 19,
U8 = 20,
F8_E4M3 = 21,
F8_E4M3FN = 21,
F8_E5M2 = 22,
// END

Expand Down
2 changes: 1 addition & 1 deletion include/dxc/DxilContainer/RDAT_LibraryTypes.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ RDAT_DXIL_ENUM_START(hlsl::DXIL::ComponentType, uint32_t)
RDAT_ENUM_VALUE_NODEF(PackedU8x32)
RDAT_ENUM_VALUE_NODEF(U8)
RDAT_ENUM_VALUE_NODEF(I8)
RDAT_ENUM_VALUE_NODEF(F8_E4M3)
RDAT_ENUM_VALUE_NODEF(F8_E4M3FN)
RDAT_ENUM_VALUE_NODEF(F8_E5M2)
RDAT_ENUM_VALUE_NODEF(LastEntry)
#if DEF_RDAT_ENUMS == DEF_RDAT_DUMP_IMPL
Expand Down
4 changes: 2 additions & 2 deletions tools/clang/lib/Headers/hlsl/dx/linalg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ enum class ComponentType : uint32_t {
// BEGIN NEW FOR SM 6.10
I8 = 19,
U8 = 20,
F8_E4M3 = 21,
F8_E4M3FN = 21,
F8_E5M2 = 22,
// END

Expand Down Expand Up @@ -116,7 +116,7 @@ struct ComponentType {
__COMPONENT_TYPE(U64),

// Floating point types.
__COMPONENT_TYPE(F8_E4M3),
__COMPONENT_TYPE(F8_E4M3FN),
__COMPONENT_TYPE(F8_E5M2),
__COMPONENT_TYPE(F16),
__COMPONENT_TYPE(F32),
Expand Down
4 changes: 2 additions & 2 deletions tools/clang/lib/Sema/SemaHLSL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17646,8 +17646,8 @@ ConvertLinAlgMatrixComponentTypeToString(hlsl::DXIL::ComponentType CompType) {
return "ComponentType::U8";
case DXIL::ComponentType::I8:
return "ComponentType::I8";
case DXIL::ComponentType::F8_E4M3:
return "ComponentType::F8_E4M3";
case DXIL::ComponentType::F8_E4M3FN:
return "ComponentType::F8_E4M3FN";
case DXIL::ComponentType::F8_E5M2:
return "ComponentType::F8_E5M2";
default:
Expand Down
2 changes: 1 addition & 1 deletion tools/clang/test/CodeGenDXIL/hlsl/linalg/attr-matrix-type.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void f1() {

// CHECK: define internal void @"\01?f2@@YAX$linalg_matrixC21M3N3U0S1@@Z"(%dx.types.LinAlgMatrixC21M3N3U0S1 %mat2.coerce)
// CHECK: %{{.*}} = alloca %dx.types.LinAlgMatrixC21M3N3U0S1, align 4
void f2(__builtin_LinAlgMatrix [[__LinAlgMatrix_Attributes(ComponentType::F8_E4M3, 3, 3, MatrixUse::A, MatrixScope::Wave)]] mat2) {
void f2(__builtin_LinAlgMatrix [[__LinAlgMatrix_Attributes(ComponentType::F8_E4M3FN, 3, 3, MatrixUse::A, MatrixScope::Wave)]] mat2) {
}

// CHECK: define internal %dx.types.LinAlgMatrixC9M10N20U0S0 @"\01?f3@@YA$linalg_matrixC9M10N20U0S0@XZ"()
Expand Down
Loading