Skip to content

Fix stale ODR-use state before lexed inline methods #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnastaZIuk wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

Fix stale ODR-use state before lexed inline methods #8324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/clang/lib/Parse/ParseCXXInlineMethods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ void Parser::ParseLexedMethodDef(LexedMethod &LM) {
// Parse the method body. Function body parsing code is similar enough
// to be re-used for method bodies as well.
ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope);
Actions.CleanupVarDeclMarking();
Actions.ActOnStartOfFunctionDef(getCurScope(), LM.D);

if (Tok.is(tok::kw_try)) {
Expand Down
15 changes: 15 additions & 0 deletions tools/clang/test/CodeGenSPIRV/ex40-lexed-inline-method-odr-use-crash.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: %dxc -HV 2021 -spirv -T cs_6_8 -E main -O0 -fspv-target-env=vulkan1.3 %s -Fo %t.spv

struct Bindings {
const static uint Mask = 0;
};

const static uint SessionDSIndex = 0;
[[vk::binding(Bindings::Mask, SessionDSIndex)]] RWTexture2DArray<float> gMask;

struct Trigger {
void accumulate() {}
};

[numthreads(1, 1, 1)]
void main(uint3 tid : SV_DispatchThreadID) {}
Loading