Skip to content

Fix StringRef build failure with newer libc++ #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsukinoko-kun wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Fix StringRef build failure with newer libc++ #8307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/llvm/ADT/StringRef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,12 @@ namespace llvm {
}

// HLSL Change Starts
// StringRef provides an operator string; that trips up the std::pair noexcept specification,
// which (a) enables the moves constructor (because conversion is allowed), but (b)
// misclassifies the the construction as nothrow.
// StringRef provides an operator string; that trips up the std::pair noexcept
// specification, which (a) enables the moves constructor (because conversion is
// allowed), but (b) misclassifies the the construction as nothrow. Newer libc++
// releases reject user specializations of this trait outright, and also compute
// the trait correctly without help.
#if !defined(_LIBCPP_VERSION)
namespace std {
template<>
struct is_nothrow_constructible <std::string, llvm::StringRef>
Expand All @@ -588,6 +591,7 @@ namespace std {
: std::false_type {
};
}
#endif
// HLSL Change Ends

#endif
Loading