Ensure DXC generators use the repository’s own .clang-format during codegen#7989
Open
Lokomojo wants to merge 1 commit intomicrosoft:mainfrom
Open
Ensure DXC generators use the repository’s own .clang-format during codegen#7989Lokomojo wants to merge 1 commit intomicrosoft:mainfrom
Lokomojo wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
I worry this could lead to another hard to diagnose bug where someone adds a .clang-format to a subdirectory that has a generate header in it. Would a more appropriate fix be to run the clang-format process over the file once it is in the final location where it will be checked in? |
Author
|
The build system runs clang-format at build time on generated content, and compares to checked in content. The generated files are not checked in unfortunately. It's definitely undefined behaviour to run clang-format without a config in the build tree (it will only find the one in the project root if the build directory happens to be inside the project root) |
Member
|
Can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format can pick a parent directory’s config when formatting generated files, leading to mismatches with checked-in headers and failing compare steps. This change ensures the repository’s .clang-format is used consistently.
Generated files are written under the build tree, which may not contain a .clang-format. clang-format searches upward and can apply an unrelated config, causing byte-level diffs and verification failures.
In cmake/modules/HCT.cmake, we mirror the repository’s .clang-format into the DXC build root so clang-format’s upward search finds the intended config.