Update Multithreading project to include Application Identity#950
Update Multithreading project to include Application Identity#950alecardoso-tech wants to merge 1 commit intomicrosoft:masterfrom
Conversation
| D3D12_APPLICATION_DESC appDesc; | ||
| appDesc.pExeFilename = L"D3D12Multithreading.exe"; | ||
| appDesc.pName = L"D3D12 Multithreading"; | ||
| appDesc.Version.Version = 0x0001000000000000; |
There was a problem hiding this comment.
Not necessarily asking for a change, but we should consider if there's something we should do to make this nicer to read.
There was a problem hiding this comment.
Right, that's the main reason why I was looking for comments/suggestions.
I was thinking of using something along the lines of:
appDesc.pEngineName = L"D3D12 Multithreading Engine";
appDesc.EngineVersion.Version = 0x0001000000000000; // 1.0.0.0And name it based on the sample.
| } | ||
|
|
||
| void D3D12Multithreading::SetApplicationIdentity() | ||
| { |
There was a problem hiding this comment.
I think its not super clear from the PR what Application Identify is, and how would devs would benefit from this. Perhaps here you can add some comments and context for the developers.
| 0xd739, | ||
| 0x485a, | ||
| { 0xa4, 0x73, 0x12, 0xdf, 0xaa, 0x19, 0x05, 0x67 } | ||
| }; |
There was a problem hiding this comment.
Probably explain how you came up with this GUID as well, might help developers understand what is within the range of "Yes this is ok" vs "no this ID won't work".
3 participants
Updated D3D12Multithreading sample to use Application Identity from AgilitySDK 1.619.