Mostly error and warning fixes.#92
Open
Jonathan-Weinstein-AMD wants to merge 3 commits intomicrosoft:developmentfrom
Open
Mostly error and warning fixes.#92Jonathan-Weinstein-AMD wants to merge 3 commits intomicrosoft:developmentfrom
Jonathan-Weinstein-AMD wants to merge 3 commits intomicrosoft:developmentfrom
Conversation
…duce potential merge conflicts.
…been based on a branch that didn't have PR microsoft#90.
…s value in keeping `const[-expr]` and not having to change multiple `if`s to `if constexpr`. zstdgpu_shaders.h(3875,24): warning C4189: 'seqMemStart': local variable is initialized but not referenced main.cpp(1230,31): warning C4127: conditional expression is constant main.cpp(...): [3 more of the above]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit with help text on an unknown/bad command line argument (intentionally entering an unknown arg like "?" can be useful to just print that). Coded in probably not the best way to reduce potential merge conflicts.
Fix the build by using symbol with
_SingleStream. PR #91 seems to have been based on a branch that didn't have PR #90.Fix warnings, see below. The
volatileis unusual, but I figured there was value in keepingconst[-expr]and not having to change multipleifs toif constexpr.