fix: WAF backend exposure and private ingress validation#149
Open
Ashwal-Microsoft wants to merge 1 commit into
Open
fix: WAF backend exposure and private ingress validation#149Ashwal-Microsoft wants to merge 1 commit into
Ashwal-Microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure that, in WAF / networkIsolation=true deployments for this accelerator, backend APIs hosted on Azure Container Apps are not publicly reachable (only the frontend should remain publicly exposed through the WAF/Application Gateway path), and adds documentation to help validate the resulting private-ingress topology after deployment.
Changes:
- Updated Container App ingress configuration in
infra/main.bicepparamso the backend app’s ingress is internal-only whennetworkIsolation=true. - Added post-deployment validation steps and deployment guide notes describing how to confirm backend Container App isolation.
- Commented out the
metadata.templateblock inazure.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/main.bicepparam | Sets backend Container App ingress to internal-only when networkIsolation=true by toggling the external flag. |
| docs/post_deployment_steps.md | Adds portal-based steps to validate backend Container App isolation in network-isolated/WAF deployments. |
| docs/deploymentguide.md | Documents expected backend reachability behavior when networkIsolation=true. |
| azure.yaml | Comments out metadata.template (template identification/version metadata). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+13
| # metadata: | ||
| # template: deploy-your-ai-application-in-production@1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the current WAF (Web Application Firewall) deployment model for solution accelerators, the API endpoints hosted on Container App (Microsoft.App/containerApps) remain publicly accessible. Only the Web App (frontend) should be publicly accessible through the WAF; all backend API endpoints should be restricted to private access only.
Accelerators in Scope
Accelerator Frontend Backend
Deploy your AI Application App Service (published from Foundry) Container App (Microsoft.App/containerApps)
When deploying these accelerators using the WAF deployment option, the expectation is that the backend APIs hosted on Container Apps are secured behind the WAF and are not directly accessible from the public internet. However, the current implementation leaves the Container App API endpoints publicly exposed, which undermines the security posture of the WAF deployment model.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information