Skip to content

Conversation

@DoctorKrolic
Copy link
Contributor

Fixes: #1430

@jevansaks
Copy link
Member

/azp run

@jevansaks
Copy link
Member

I checked out this branch locally and started running tests and I see a few test failures -- "GeneratorTests.InterestingAPIs":

Windows.Win32.NativeMethods.g.cs(64,33): error CS1503: Argument 2: cannot convert from 'Windows.Win32.Security.Cryptography.NCRYPT_KEY_HANDLE' to 'nint'

@DoctorKrolic If you can, run tests locally in Test Explorer. Ideally the full set, but the "Full" generation tests can take a long time so I'm ok if you just run the "No Traits" set before putting up a PR:

image

Click the "Group By" button in task explorer to group by Traits and then run the "No Traits" set:

image

@DoctorKrolic
Copy link
Contributor Author

run tests locally in Test Explorer

Is there a apecific reason why CI is blocked here from "untrusted" contributors? I am used to rely on CI to uncover test failures and all repos in dotnet org I worked with have their CI open to any contributor. It seems very inconvinient, that you have to manually trigger CI run every time I make a commit

@jevansaks
Copy link
Member

Is there a apecific reason why CI is blocked here from "untrusted" contributors? I am used to rely on CI to uncover test failures and all repos in dotnet org I worked with have their CI open to any contributor. It seems very inconvinient, that you have to manually trigger CI run every time I make a commit

I defer to @AArnott who set up the pipelines. This may be because the pipelines are in ADO and if they were GitHub actions it would be safer to run them automatically? Not sure. It's like this in a lot of repos I work in.

@jevansaks
Copy link
Member

/azp run

@jevansaks jevansaks merged commit 3686850 into microsoft:main Jan 16, 2026
3 checks passed
@DoctorKrolic DoctorKrolic deleted the init-handle branch January 16, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource leak if allocation of SafeHandle fails

2 participants