Skip to content

chore: dev to main merge#914

Merged
Prajwal-Microsoft merged 30 commits into
mainfrom
dev
May 18, 2026
Merged

chore: dev to main merge#914
Prajwal-Microsoft merged 30 commits into
mainfrom
dev

Conversation

@Ragini-Microsoft
Copy link
Copy Markdown
Contributor

@Ragini-Microsoft Ragini-Microsoft commented May 14, 2026

Purpose

This pull request updates documentation to reflect a migration from Azure Container Apps to Azure App Service for hosting the application's web front-end and backend APIs. It also updates related security and troubleshooting guidance to align with this change. The most important changes are grouped below.

Service Architecture and Deployment Documentation:

  • Replaces references to Azure Container Apps with Azure App Service as the primary hosting platform for the web application and backend API in README.md and documents/DeploymentGuide.md. Updates include descriptions, pricing, and links to relevant Azure documentation. [1] [2]

Security Guidance:

  • Updates security recommendations to use Virtual Networks or access restrictions for Azure App Service, replacing previous guidance for Azure Container Apps.

Troubleshooting Documentation:

  • Removes troubleshooting steps and quota error documentation related to Azure Container Apps, including regional environment limits and managed environment deletion errors, and adds/updates guidance for Azure App Service capacity and related issues in documents/TroubleShootingSteps.md. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Yamini-Microsoft and others added 21 commits May 12, 2026 19:17
Remove unconditional hideCitation() call from onHandlePanelStates so
toggling one panel no longer closes the other. Citation is still
correctly dismissed on conversation switch and history clear.

Fixes #43310

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ge account and added e2eEncryption in app service
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Use an async Azure credential for the async CosmosClient in HistoryService.init_cosmosdb_client. The previous sync ManagedIdentityCredential, when paired with azure.cosmos.aio.CosmosClient, could fail to refresh tokens cleanly after an idle period, causing DELETE /history/delete_all to return 500. Single-conversation delete was unaffected because it bypasses the query_items async iterator path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move CitationPanel outside the flex layout container (.main-container)
and render it as a fixed-position overlay. This prevents the two panels
from competing for flex space, which caused:
- Closing Chat History to also close Citation panel
- Opening Citation to push Chat History off-screen

Fixes AB#43310

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: Added data collection rules for VM, added double encryption for storage account and added e2eEncryption in app service
Address review feedback: CitationPanel is now a flex participant
inside .main-container using .citation-panel-wrapper (flex: 0 0 20%)
instead of a fixed-position overlay. This reserves layout space and
avoids blocking clicks on underlying panels.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…istory

Citation panel is now a fixed overlay that dynamically offsets its
position when Chat History is open, preventing click-blocking while
maintaining full panel independence.

- Overlay shifts left by Chat History width when both panels are open
- Panels remain fully independent (opening/closing one never affects the other)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The simple overlay approach is the cleanest solution - Citation floats
independently without any coupling to the flex layout. Tested and
verified that all 4 panels (Dashboard, Chat, Citation, Chat History)
work correctly side by side.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Extract --header-height CSS custom property to avoid 6vh duplication
- Add pointer-events: none on overlay container to prevent dead zones
- Use <section> with aria-label for citation overlay accessibility

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • src/App/package-lock.json: Language not supported

Comment thread README.md
Comment thread src/api/helpers/azure_credential_utils.py Outdated
Comment thread src/App/src/App.tsx Outdated
…ential

Addresses Copilot review feedback on PR #915 (merged into dev). The two helpers get_azure_credential_async (async fn) and get_async_azure_credential (sync fn) differ only by word order, which is easy to confuse at call sites. Renaming the sync builder to build_async_azure_credential makes the sync-vs-async distinction explicit: build_ implies sync construction, async describes the returned credential type.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yamini-Microsoft and others added 3 commits May 15, 2026 02:42
- Use flex-based citation-panel-wrapper for consistent height alignment
- Add box-sizing: border-box to include padding/border in height calc
- Prevent horizontal overflow on main-container

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Citation should close when Chat panel is hidden since citations
originate from chat responses. ChatHistory toggle remains independent.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/App/package-lock.json: Language not supported

Comment thread infra/main_custom.bicep
@Prajwal-Microsoft Prajwal-Microsoft merged commit 5f1ae0a into main May 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants