chore: dev to main merge#914
Merged
Merged
Conversation
Remove unconditional hideCitation() call from onHandlePanelStates so toggling one panel no longer closes the other. Citation is still correctly dismissed on conversation switch and history clear. Fixes #43310 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ge account and added e2eEncryption in app service
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Use an async Azure credential for the async CosmosClient in HistoryService.init_cosmosdb_client. The previous sync ManagedIdentityCredential, when paired with azure.cosmos.aio.CosmosClient, could fail to refresh tokens cleanly after an idle period, causing DELETE /history/delete_all to return 500. Single-conversation delete was unaffected because it bypasses the query_items async iterator path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Move CitationPanel outside the flex layout container (.main-container) and render it as a fixed-position overlay. This prevents the two panels from competing for flex space, which caused: - Closing Chat History to also close Citation panel - Opening Citation to push Chat History off-screen Fixes AB#43310 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: Added data collection rules for VM, added double encryption for storage account and added e2eEncryption in app service
Address review feedback: CitationPanel is now a flex participant inside .main-container using .citation-panel-wrapper (flex: 0 0 20%) instead of a fixed-position overlay. This reserves layout space and avoids blocking clicks on underlying panels. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…istory Citation panel is now a fixed overlay that dynamically offsets its position when Chat History is open, preventing click-blocking while maintaining full panel independence. - Overlay shifts left by Chat History width when both panels are open - Panels remain fully independent (opening/closing one never affects the other) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The simple overlay approach is the cleanest solution - Citation floats independently without any coupling to the flex layout. Tested and verified that all 4 panels (Dashboard, Chat, Citation, Chat History) work correctly side by side. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Extract --header-height CSS custom property to avoid 6vh duplication - Add pointer-events: none on overlay container to prevent dead zones - Use <section> with aria-label for citation overlay accessibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ential Addresses Copilot review feedback on PR #915 (merged into dev). The two helpers get_azure_credential_async (async fn) and get_async_azure_credential (sync fn) differ only by word order, which is easy to confuse at call sites. Renaming the sync builder to build_async_azure_credential makes the sync-vs-async distinction explicit: build_ implies sync construction, async describes the returned credential type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
- Use flex-based citation-panel-wrapper for consistent height alignment - Add box-sizing: border-box to include padding/border in height calc - Prevent horizontal overflow on main-container Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Citation should close when Chat panel is hidden since citations originate from chat responses. ChatHistory toggle remains independent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ential (address Copilot review on #915)
Avijit-Microsoft
approved these changes
May 18, 2026
Prajwal-Microsoft
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates documentation to reflect a migration from Azure Container Apps to Azure App Service for hosting the application's web front-end and backend APIs. It also updates related security and troubleshooting guidance to align with this change. The most important changes are grouped below.
Service Architecture and Deployment Documentation:
README.mdanddocuments/DeploymentGuide.md. Updates include descriptions, pricing, and links to relevant Azure documentation. [1] [2]Security Guidance:
Troubleshooting Documentation:
documents/TroubleShootingSteps.md. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation