Skip to content

chore: dev to main merge#903

Merged
Roopan-Microsoft merged 15 commits into
mainfrom
dev
May 11, 2026
Merged

chore: dev to main merge#903
Roopan-Microsoft merged 15 commits into
mainfrom
dev

Conversation

@Ragini-Microsoft
Copy link
Copy Markdown
Contributor

@Ragini-Microsoft Ragini-Microsoft commented May 7, 2026

Purpose

This pull request makes significant updates to deployment scripts, documentation, and infrastructure configuration to streamline regional support, remove the separate Content Understanding (CU) resource, and improve parameter validation and notifications. The changes simplify resource deployment, clarify region requirements, and enhance validation feedback.

Key changes include:

Infrastructure and Deployment Updates:

  • Removed the separate Content Understanding (CU) resource and its parameters from infra/main.bicep, deployment scripts, and outputs, consolidating all AI Foundry and CU functionality into a single resource and endpoint. This simplifies deployments and eliminates the need for the contentUnderstandingLocation parameter. [1] [2] [3] [4] [5]
  • Expanded and updated the list of supported regions for deployments and quota checks, both in Bicep parameters and documentation. Removed francecentral and added regions such as southcentralus and westeurope. [1] [2] [3]

Parameter Validation and Notification Enhancements:

  • Improved the Bicep parameter validation workflow to generate an HTML report (email_body.html) and use it in email notifications, providing more detailed and user-friendly feedback on validation results. [1] [2] [3]

Documentation Improvements:

  • Updated deployment and customization guides to remove references to the separate CU Foundry resource, clarify required parameters, and document the new region requirements for reusing an existing Foundry project. [1] [2] [3] [4] [5] [6]
  • Corrected and clarified instructions for app registration and parameter usage. [1] [2]

Configuration File Updates:

  • Renamed and updated analyzer configuration files to use new base analyzers and removed obsolete fields, aligning with the updated resource structure. [1] [2]

These changes collectively simplify deployment, improve clarity for users, and ensure compatibility with supported Azure regions.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Thanusree-Microsoft and others added 9 commits April 17, 2026 18:52
Updated AddPlatform.png and Web.png with latest Azure portal UI.
Updated step 6 from 'Add a platform' to 'Add redirect URI' in create_new_app_registration.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Migrate CU API from 2024-12-01-preview to 2025-11-01 GA
- Upgrade GPT model from gpt-4o-mini to gpt-4.1
- Consolidate CU resource into main AI Foundry resource
- Rename analyzers: ckm-json -> ckm_analyzer_json, ckm-audio -> ckm_analyzer_audio
- Migrate embeddings from deprecated azure-ai-inference SDK to OpenAI v1 SDK
- Remove francecentral region, update quota checks
- Update Bicep, shell scripts, Python scripts, and documentation

Resolves AB#41640

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: Enhance delete_all_conversations to handle transient connection error with a retry mechanism
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
src/api/api
   history_routes.py2563984%42, 159, 163, 241–243, 248–252, 268, 272, 400, 404, 407, 410, 430, 433–436, 441–445, 462, 466, 477, 481, 495–497, 503–507
TOTAL131015188% 

Tests Skipped Failures Errors Time
163 0 💤 0 ❌ 0 🔥 5.930s ⏱️

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves robustness of the /history/delete_all endpoint by retrying conversation listing once to mitigate transient Cosmos DB connection issues after idle periods, and by ensuring FastAPI HTTPExceptions aren’t masked as generic 500s. Also updates a documentation step for clarity in app registration setup.

Changes:

  • Added a one-time retry when listing conversations prior to deleting all conversations.
  • Re-raised HTTPException in delete_all_conversations so the correct HTTP status codes are returned.
  • Updated an app registration instruction from “Add a platform” to “Add redirect URI”.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 4 comments.

File Description
src/api/api/history_routes.py Adds retry logic around get_conversations for delete-all and avoids masking HTTPException as 500.
documents/create_new_app_registration.md Clarifies the UI step for adding a redirect URI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/api/api/history_routes.py
Comment thread src/api/api/history_routes.py
Comment thread src/api/api/history_routes.py
Comment thread documents/create_new_app_registration.md
Harsh-Microsoft and others added 3 commits May 7, 2026 16:50
…ed regions

- Switch default GPT model to gpt-4o-mini (version 2024-07-18) per lead decision after model comparison evaluation

- Add southcentralus and westeurope to allowed aiServiceLocation regions (intersection of gpt-4o-mini GlobalStandard, text-embedding-3-small GlobalStandard, and Content Understanding GA availability)

- Update quota scripts, region lists, pricing example, and customization docs accordingly

- Add Standard vs GlobalStandard usageName note in CustomizingAzdParameters.md

- Add region requirement callout to re-use-foundry-project.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Harsh-Microsoft and others added 2 commits May 7, 2026 19:45
Wraps the �mbeddings_client = AsyncOpenAI(...) usage in process_files()
inside a try/finally that calls �wait embeddings_client.close() so the
underlying httpx connection pool is released, addressing reviewer feedback
about leaked HTTP connections / unclosed-client warnings.

Applied to both:
- infra/scripts/index_scripts/03_cu_process_data_text.py
- infra/scripts/index_scripts/04_cu_process_custom_data.py

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chore: Bicep Parameter validation email format change
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 32 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

infra/scripts/index_scripts/content_understanding_client.py:281

  • get_file_from_analyze_operation still asserts Content-Type == 'image/jpeg' even though it now retrieves an arbitrary file from /files/{file_path}. This assertion can fail for non-JPEG outputs (or for headers like image/jpeg; charset=...) and crash consumers; consider removing the assertion or validating against the expected MIME type for the specific requested file.
            response = requests.get(url=file_retrieval_url, headers=self._headers)
            response.raise_for_status()

            assert response.headers.get("Content-Type") == "image/jpeg"

            return response.content

Comment thread src/api/api/history_routes.py
Comment thread infra/scripts/index_scripts/content_understanding_client.py
Comment thread infra/scripts/index_scripts/03_cu_process_data_text.py
Comment thread infra/scripts/index_scripts/04_cu_process_custom_data.py
Comment thread infra/main.bicep
@Roopan-Microsoft Roopan-Microsoft merged commit d8d5565 into main May 11, 2026
38 of 39 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.22.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants