chore: dev to main merge#903
Conversation
Updated AddPlatform.png and Web.png with latest Azure portal UI. Updated step 6 from 'Add a platform' to 'Add redirect URI' in create_new_app_registration.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Migrate CU API from 2024-12-01-preview to 2025-11-01 GA - Upgrade GPT model from gpt-4o-mini to gpt-4.1 - Consolidate CU resource into main AI Foundry resource - Rename analyzers: ckm-json -> ckm_analyzer_json, ckm-audio -> ckm_analyzer_audio - Migrate embeddings from deprecated azure-ai-inference SDK to OpenAI v1 SDK - Remove francecentral region, update quota checks - Update Bicep, shell scripts, Python scripts, and documentation Resolves AB#41640 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…s with a retry mechanism
docs: Image update
fix: Enhance delete_all_conversations to handle transient connection error with a retry mechanism
There was a problem hiding this comment.
Pull request overview
Improves robustness of the /history/delete_all endpoint by retrying conversation listing once to mitigate transient Cosmos DB connection issues after idle periods, and by ensuring FastAPI HTTPExceptions aren’t masked as generic 500s. Also updates a documentation step for clarity in app registration setup.
Changes:
- Added a one-time retry when listing conversations prior to deleting all conversations.
- Re-raised
HTTPExceptionindelete_all_conversationsso the correct HTTP status codes are returned. - Updated an app registration instruction from “Add a platform” to “Add redirect URI”.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/api/api/history_routes.py | Adds retry logic around get_conversations for delete-all and avoids masking HTTPException as 500. |
| documents/create_new_app_registration.md | Clarifies the UI step for adding a redirect URI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ed regions - Switch default GPT model to gpt-4o-mini (version 2024-07-18) per lead decision after model comparison evaluation - Add southcentralus and westeurope to allowed aiServiceLocation regions (intersection of gpt-4o-mini GlobalStandard, text-embedding-3-small GlobalStandard, and Content Understanding GA availability) - Update quota scripts, region lists, pricing example, and customization docs accordingly - Add Standard vs GlobalStandard usageName note in CustomizingAzdParameters.md - Add region requirement callout to re-use-foundry-project.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wraps the �mbeddings_client = AsyncOpenAI(...) usage in process_files() inside a try/finally that calls �wait embeddings_client.close() so the underlying httpx connection pool is released, addressing reviewer feedback about leaked HTTP connections / unclosed-client warnings. Applied to both: - infra/scripts/index_scripts/03_cu_process_data_text.py - infra/scripts/index_scripts/04_cu_process_custom_data.py Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chore: Bicep Parameter validation email format change
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 32 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
infra/scripts/index_scripts/content_understanding_client.py:281
get_file_from_analyze_operationstill assertsContent-Type == 'image/jpeg'even though it now retrieves an arbitrary file from/files/{file_path}. This assertion can fail for non-JPEG outputs (or for headers likeimage/jpeg; charset=...) and crash consumers; consider removing the assertion or validating against the expected MIME type for the specific requested file.
response = requests.get(url=file_retrieval_url, headers=self._headers)
response.raise_for_status()
assert response.headers.get("Content-Type") == "image/jpeg"
return response.content
|
🎉 This PR is included in version 3.22.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This pull request makes significant updates to deployment scripts, documentation, and infrastructure configuration to streamline regional support, remove the separate Content Understanding (CU) resource, and improve parameter validation and notifications. The changes simplify resource deployment, clarify region requirements, and enhance validation feedback.
Key changes include:
Infrastructure and Deployment Updates:
infra/main.bicep, deployment scripts, and outputs, consolidating all AI Foundry and CU functionality into a single resource and endpoint. This simplifies deployments and eliminates the need for thecontentUnderstandingLocationparameter. [1] [2] [3] [4] [5]francecentraland added regions such assouthcentralusandwesteurope. [1] [2] [3]Parameter Validation and Notification Enhancements:
email_body.html) and use it in email notifications, providing more detailed and user-friendly feedback on validation results. [1] [2] [3]Documentation Improvements:
Configuration File Updates:
These changes collectively simplify deployment, improve clarity for users, and ensure compatibility with supported Azure regions.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation