fix: dev to main - DevContainer Tooling Update and constants.py API Cleanup#894
Merged
Conversation
fix: code quality issue
fix: install latest bicep via CLI
Pavan-Microsoft
changed the title
Pavan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR clarifies the public API of the E2E test constants module via __all__ and updates the DevContainer’s Azure CLI feature configuration (including Bicep installation/versioning).
Changes:
- Define
__all__intests/e2e-test/config/constants.pyto explicitly mark intended exports. - Update
.devcontainer/devcontainer.jsonAzure CLI feature settings to install Bicep and specify versions aslatest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e-test/config/constants.py | Adds __all__ to explicitly define the module’s public exports. |
| .devcontainer/devcontainer.json | Expands Azure CLI feature configuration (Bicep install + version settings). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 5, 2026
Avijit-Microsoft
approved these changes
May 5, 2026
Contributor
|
🎉 This PR is included in version 3.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request contains a couple of targeted improvements to the development environment configuration and the test constants. The main changes are an enhancement to the Azure CLI feature in the devcontainer setup and the addition of explicit public exports in the test constants module.
Development environment improvements:
.devcontainer/devcontainer.jsonto ensure Bicep is installed with the latest version, improving infrastructure-as-code support.Test module enhancements:
__all__declaration intests/e2e-test/config/constants.pyto explicitly define the module's public API, making imports clearer and more maintainable.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation