Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds assertions to verify ledger chunking determinism and ensures that chunk end transactions have the correct flags set. The PR introduces a new skip_verify_chunking parameter to allow selective bypassing of these checks in tests where ledger files are intentionally modified or when working with older CCF versions that may not have complete chunking flags.
Changes:
- Added
check_ledger_files_chunk_flagsmethod to verify chunking flags in ledger files - Introduced
skip_verify_chunkingparameter throughout the network infrastructure - Added
CCFVersionclass for more robust version comparisons - Updated compatibility tests to skip chunk verification for pre-7.0.0 versions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/infra/network.py | Added chunking verification logic and skip_verify_chunking parameter support |
| tests/infra/node.py | Added CCFVersion class for version comparisons and updated version_after logic |
| tests/infra/remote.py | Updated ledger_paths to filter out non-existent paths |
| tests/lts_compatibility.py | Added version-specific logic to skip chunk verification for older versions |
| tests/recovery.py | Enabled skip_verify_chunking for recovery tests using pre-existing ledger files |
| tests/e2e_operations.py | Enabled skip_verify_chunking for tests that intentionally modify ledger files |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ring from eol services
eddyashton
reviewed
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently are somewhat lax about two of the claims we make, that chunking is deterministic, which is often unchecked and unchecked in LTS; and that a chunk's end has the relevant tx flag set such that it is recreated on followers correctly.
This PR adds those checks, in draft mode for now until everything is fixed.