[Shopify] Fix Shopify refund/return deletion wiping all lines#7320
Open
[Shopify] Fix Shopify refund/return deletion wiping all lines#7320
Conversation
SetRange calls in OnDelete triggers were missing the value parameter, causing DeleteAll to operate on the entire line table instead of only the lines belonging to the deleted header. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
onbuyuka
changed the title
…uka/fix-shopify-refund-return-line-deletion
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Shopify-Connector: 7% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetRange("Field Name")inOnDeletetriggers was called without a value parameter, which clears the filter instead of setting it — causingDeleteAllto wipe the entire line tableRec."Refund Id"/Rec."Return Id"as the second parameter toSetRangein 3 locations across 2 filesFixes AB#626081
🤖 Generated with Claude Code