Skip to content

Refactor procedures to remove internal access modifier in E-Document Log and WorkFlow Processing#6498

Merged
JesperSchulz merged 1 commit intomicrosoft:mainfrom
MattiLE:access/Edocument6497
Mar 6, 2026
Merged

Refactor procedures to remove internal access modifier in E-Document Log and WorkFlow Processing#6498
JesperSchulz merged 1 commit intomicrosoft:mainfrom
MattiLE:access/Edocument6497

Conversation

@MattiLE
Copy link
Contributor

@MattiLE MattiLE commented Feb 5, 2026 •
edited by github-actions bot
Loading

Fixes AB#621397

@MattiLE MattiLE requested a review from a team as a code owner February 5, 2026 08:37
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Feb 5, 2026
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Issue #6497 is not valid. Please make sure you link an issue that exists, is open and is approved.

@Groenbech96 Groenbech96 added Approved The issue is approved Linked Issue is linked to a Azure Boards work item labels Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 16, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@Groenbech96 Groenbech96 reopened this Feb 17, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Feb 17, 2026
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@aholstrup1 aholstrup1 modified the milestones: Version 28.0, Version 29.0 Feb 25, 2026
@JesperSchulz JesperSchulz reopened this Feb 26, 2026
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 5, 2026

Not sure what is going on with this one... Trying one last time to re-trigger CI, before it's send to engineering systems.

@JesperSchulz JesperSchulz reopened this Mar 5, 2026
@JesperSchulz JesperSchulz enabled auto-merge (squash) March 6, 2026 12:22
@JesperSchulz JesperSchulz merged commit 44d58e0 into microsoft:main Mar 6, 2026
107 of 117 checks passed
@MattiLE
Copy link
Contributor Author

MattiLE commented Mar 20, 2026

Hi @JesperSchulz , will this change be included in BC28? That would be important to me.
I tried to figure it out myself by looking at the PR, but I couldn't come to a clear conclusion.

@darjoo
Copy link
Contributor

darjoo commented Mar 20, 2026

Hi @JesperSchulz , will this change be included in BC28? That would be important to me. I tried to figure it out myself by looking at the PR, but I couldn't come to a clear conclusion.

It is not in 28.0 and we won't be able to get it into that at this time. At we could get it in for 28.1.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 20, 2026

You can always check what's in a branch by changing branch and checking:
image

As Darrick says, 28.0 is a done deal. But you can cherry-pick this commit to the releases/28.x branch, and your changes will release with 28.1!

@MattiLE
Copy link
Contributor Author

MattiLE commented Mar 20, 2026

@JesperSchulz @darjoo
Okay, then 28.1 would be great. :)
Thank you for the note and the quick reply.

JesperSchulz pushed a commit that referenced this pull request Mar 23, 2026
@MattiLE @JesperSchulz
Refactor procedures to remove internal access modifier in E-Document …
3d8c271 
…Log and WorkFlow Processing (#6498)

Fixes
[AB#621397](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621397)
@JesperSchulz JesperSchulz mentioned this pull request Mar 23, 2026
Merged
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 23, 2026

@JesperSchulz @darjoo Okay, then 28.1 would be great. :) Thank you for the note and the quick reply.

Backport PR created: #7321

JesperSchulz added a commit that referenced this pull request Mar 24, 2026
@JesperSchulz @MattiLE
[28.x] Refactor procedures to remove internal access modifier in E-Do…
d8741b4 
…cument … (#7321)

Backport of #6498.


Fixes
[AB#626508](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/626508)

Co-authored-by: MattiLE <48024891+MattiLE@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Groenbech96 Groenbech96 Groenbech96 approved these changes

@JesperSchulz JesperSchulz JesperSchulz approved these changes

Assignees

@Groenbech96 Groenbech96

Labels

AL: Apps (W1) Add-on apps for W1 Approved The issue is approved From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 29.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MattiLE @JesperSchulz @darjoo @Groenbech96 @aholstrup1