Allowing E-Document Attachments to be PDF

[miljance]

Summary

• Allowing E-Document module to support any extension for an E-document. Currently *.xml for most of the services except for ZUGFeRD where PDF is used.
• Each connector that does not use *.xml format should subscribe to OnAfterGetFileExtension and ship file extension back.
• There is another Pull Request on ALApExtension for ZUGFeRD
• Base for Managing PDF File Extension for ZUGFeRD ALAppExtensions#29341

Work Item(s)

Fixes #5220 and #5104

Fixes AB#611441

[JesperSchulz]

Looks like we've got another codecop issue: Possible overflow assigning 'Text' to 'Text[4]'.

[pri-kise]

Looks like we've got another codecop issue: Possible overflow assigning 'Text' to 'Text[4]'.

@miljance the problem seems to be the parametere var AttachmentFileExtension: Text[4] of the CreateAttachmentsBlob.

I would refactor this procedure, to only return a AttachmentFileNameWithExtension with a Max Length of 250 (This is the maximium length in the BaseApp).

I had a similiar requirement in the past to trim a filename:

// This shortens the filename but keeps the file extension.
    procedure ShortenFileName(FileName: Text): Text[250]
    var
        FileManagement: Codeunit "File Management";
        MaxFileNameWithoutExtensionLength: Integer;
        Extension: Text;
        FileNameWithoutExtension: Text;
        FileNameWithFixedLength: Text[250];
    begin
        if StrLen(FileName) <= MaxStrLen(FileNameWithFixedLength) then begin
            FileNameWithFixedLength := CopyStr(FileName, 1, MaxStrLen(FileNameWithFixedLength));
            exit(FileNameWithFixedLength);
        end;
        FileNameWithoutExtension := FileManagement.GetFileNameWithoutExtension(FileName);
        Extension := FileManagement.GetExtension(FileName);
        MaxFileNameWithoutExtensionLength := MaxStrLen(FileNameWithFixedLength) - StrLen(Extension) - 1;
        FileNameWithFixedLength := CopyStr(FileNameWithoutExtension, 1, MaxFileNameWithoutExtensionLength) + '.' + Extension;
        exit(FileNameWithFixedLength);
    end;

[miljance]

Looks like we've got another codecop issue: Possible overflow assigning 'Text' to 'Text[4]'.

@miljance the problem seems to be the parametere var AttachmentFileExtension: Text[4] of the CreateAttachmentsBlob.

I would refactor this procedure, to only return a AttachmentFileNameWithExtension with a Max Length of 250 (This is the maximium length in the BaseApp).

I had a similiar requirement in the past to trim a filename:

// This shortens the filename but keeps the file extension.
    procedure ShortenFileName(FileName: Text): Text[250]
    var
        FileManagement: Codeunit "File Management";
        MaxFileNameWithoutExtensionLength: Integer;
        Extension: Text;
        FileNameWithoutExtension: Text;
        FileNameWithFixedLength: Text[250];
    begin
        if StrLen(FileName) <= MaxStrLen(FileNameWithFixedLength) then begin
            FileNameWithFixedLength := CopyStr(FileName, 1, MaxStrLen(FileNameWithFixedLength));
            exit(FileNameWithFixedLength);
        end;
        FileNameWithoutExtension := FileManagement.GetFileNameWithoutExtension(FileName);
        Extension := FileManagement.GetExtension(FileName);
        MaxFileNameWithoutExtensionLength := MaxStrLen(FileNameWithFixedLength) - StrLen(Extension) - 1;
        FileNameWithFixedLength := CopyStr(FileNameWithoutExtension, 1, MaxFileNameWithoutExtensionLength) + '.' + Extension;
        exit(FileNameWithFixedLength);
    end;

The overflow comes from using Text[4] for AttachmentFileExtension in CreateAttachmentsBlob.
I applied a minimal fix that resolves the CodeCop warning without introducing broader changes.
File extensions can be longer than 4 chars (including dot).
While the suggested refactor is valid in order to make sure no long file names are created, it feels beyond the scope of this bugfix.

@djukicmilica or @JesperSchulz please let me know if you think it makes sense to deal with file name length limitation in the scope of this change.

[JesperSchulz]

@miljance, let's keep focus and deal with the file name length limitation in a separate PR. Time to get this merged.