Fix minor issue with E2E test #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a minor issue in the E2E test suite by removing an unnecessary error assignment and updates various npm dependencies in the lockfile.
- Removes an unused error assignment (
this._ctx.err = e;) in a catch block - Updates multiple npm packages to their latest minor/patch versions
- Adds imports to the test file (though some appear unused)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common/config/rush/npm-shrinkwrap.json | Updates various npm dependencies including @eslint/js (9.39.1→9.39.2), @microsoft/api-extractor (7.55.1→7.55.2), @typescript-eslint packages (8.48.1→8.50.1), browserslist (4.28.0→4.28.1), and other supporting packages to their latest versions |
| AISKU/Tests/Unit/src/applicationinsights.e2e.tests.ts | Removes unused error assignment in catch block and adds several imports from @nevware21/ts-async (though most appear unused) |
Files not reviewed (1)
- common/config/rush/npm-shrinkwrap.json: Language not supported
MSNev
force-pushed
the
MSNev/FixE2ETest
branch
from
0792228 to
7dadb1d
Compare
rads-1996
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.