Follow up PR: Address feedback on OTEL Logs SDK #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds noop (no-operation) implementations for the OpenTelemetry metrics API, enabling the SDK to provide safe default behavior when metrics functionality is disabled or not configured. The PR introduces two new interface type definitions and two noop factory functions.
Key changes:
- Added
IObservableCallbackandIMetricAttributestype definitions for metrics support - Implemented
createNoopMeter()andcreateNoopMeterProvider()factory functions that return non-functional metric implementations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
shared/OpenTelemetry/src/interfaces/metrics/meter/IObservableCallback.ts |
Defines callback type for observable metrics with generic attribute types |
shared/OpenTelemetry/src/interfaces/metrics/meter/IMetricAttributes.ts |
Type alias for metric attributes extending base OTel attributes |
shared/OpenTelemetry/src/api/noop/noopMeterProvider.ts |
Factory function creating noop meter provider implementation |
shared/OpenTelemetry/src/api/noop/noopMeter.ts |
Factory functions for noop meter and all metric types (Counter, Gauge, Histogram, Observable variants) |
shared/OpenTelemetry/src/interfaces/metrics/meter/IObservableCallback.ts
Outdated
Show resolved
Hide resolved
rads-1996
changed the title
MSNev
reviewed
Dec 11, 2025
| const handlers: IOTelErrorHandlers = {}; | ||
| const attributeContainer = createAttributeContainer<any>( | ||
| { | ||
| traceCfg: { |
Collaborator
There was a problem hiding this comment.
The config should be injected from the main config and not applied here as it's own version (non-user configurable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.