[Beta] Merge [main] Separate BeaconSendFailure from SizeLimitExceeded #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed (#2642) * Separate BeaconSendFailure and BeaconSendFailure from SizeLimitExceeded to make it easier to troubleshoot SizeLimitExceeded errors * PR feedback
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new BeaconSendFailure reason to distinguish beacon API failures from payload size limit violations, and adds an optional sendType parameter to events discarded notifications to provide better context about how events were being sent when discarded.
- Adds
BeaconSendFailureas a new events discarded reason (value 6) to differentiate beacon API failures from size limit exceeded errors - Adds optional
sendTypeparameter to the eventsDiscarded notification signature across all interfaces and implementations - Updates HttpManager to use
BeaconSendFailurewhen beacon API fails after passing serializer size validation
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/AppInsightsCore/src/JavaScriptSDK.Enums/EventsDiscardedReason.ts | Adds new BeaconSendFailure enum value (6) to both const enum and exported constant |
| shared/AppInsightsCore/src/JavaScriptSDK.Interfaces/INotificationListener.ts | Adds optional sendType parameter to eventsDiscarded method signature |
| shared/AppInsightsCore/src/JavaScriptSDK.Interfaces/INotificationManager.ts | Adds optional sendType parameter to eventsDiscarded method signature |
| shared/AppInsightsCore/src/JavaScriptSDK/NotificationManager.ts | Propagates optional sendType parameter through to registered listeners |
| channels/1ds-post-js/src/DataModels.ts | Adds BeaconSendFailure = 8006 to EventBatchNotificationReason enum for proper range mapping |
| channels/1ds-post-js/src/HttpManager.ts | Updates beacon retry logic to use BeaconSendFailure reason and adds it to event action map |
| channels/1ds-post-js/src/PostChannel.ts | Updates internal notification functions to accept and pass sendType parameter |
| tools/chrome-debug-extension/src/pageHelper.ts | Updates debug extension to accept and forward sendType in notifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.