[Main][Task] 35656109: [Snippet] Fix Snippet Loader Error #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the Application Insights web snippet loader by properly handling sourcemap comments in the generated SDK loader script. The fix extracts sourcemap comments from the original snippet before wrapping it in an IIFE, then re-appends the comment after the function to prevent loader errors.
Key Changes:
- Added utility function to extract and preserve sourcemap comments
- Modified SDK loader script generation to handle sourcemap comments separately
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/applicationinsights-web-snippet/src/common/utils.ts | Added _getSourceMap utility function to extract sourcemap comments from code strings |
| tools/applicationinsights-web-snippet/src/applicationinsights-web-snippet.ts | Updated getSdkLoaderScript to extract sourcemap comments before wrapping code and re-append them after |
tools/applicationinsights-web-snippet/src/applicationinsights-web-snippet.ts
Show resolved
Hide resolved
Contributor
Author
hectorhdzg
reviewed
Oct 22, 2025
|
|
||
| let configString: string = JSON.stringify(snippetConfig); | ||
| return "!(function (cfg){" + originSnippet + "}})(\n" + configString + "\n);"; | ||
| let result = "!(function (cfg){" + cleanedSnippet + "})(\n" + configString + "\n);"; |
Member
There was a problem hiding this comment.
Let's make sure we have unit tests for snippet creation so this do not happen in the future
hectorhdzg
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.