-
Notifications
You must be signed in to change notification settings - Fork 255
[Draft][Beta] Add startSpan, withSpan, Route Strategy #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MSNev
wants to merge
5
commits into
beta
Choose a base branch
from
MSNev/TraceStateBeta
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Sep 18, 2025
- Attribute Container with inheritance
- Initial OTelAPI with span creation
shared/AppInsightsCore/src/OpenTelemetry/attribute/attributeContainer.ts
Fixed
Show fixed
Hide fixed
shared/AppInsightsCore/src/OpenTelemetry/interfaces/config/IOTelTraceCfg.ts
Fixed
Show fixed
Hide fixed
f8bce57 to
4bd44b0
Compare
bc8e145 to
e7b0b79
Compare
MSNev
commented
Sep 22, 2025
- Attribute Container with inheritance - Initial OTelAPI with span creation - Prior to Removing IOTelContext, IOTelContextManager and IOTelSpanContext
Change API Surface - Use IReadableSpan instead of IOTelSpan Removed - IOTelSpanContext (use IDistributedTraceContext instead) - IOTelLink - IOTelContext - IOTelContextManager Renamed - IOTelTraceCfg -> ITraceCfg - IOTelTraceApi -> ITraceApi Changed - IReadableSpan - removed droppedEventCount - removed droppedLinksCount - changed spanContext, parentSpanContext return IDistributedTraceContext instead - ITraceApi - add getActiveSpan, setActiveSpan - IOTelApi - removed context (IOTelContextManager) - ITraceCfg - added suppressTracing config
…nclude in the build
e7b0b79 to
0d494ec
Compare
1bf69c4 to
207affd
Compare
294e4fb to
c2f2008
Compare
- add additional tests - Changed to only create OTel SDK after initialization - Negative tests - Refactor to use ITraceHost instead of core - Add URL redaction - Additional tests - Remove truncation
c2f2008 to
5014727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.