Fix .binvox files being saved with the inverse scale#4710
Open
sotpapathe wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix .binvox files being saved with the inverse scale#4710sotpapathe wants to merge 1 commit intomicrosoft:mainfrom
sotpapathe wants to merge 1 commit intomicrosoft:mainfrom
Conversation
According to the specification the scale stored in binvox should be what the normalized voxel coordinates (in the interval [0, 1]) should be scaled by. https://www.patrickmin.com/binvox/binvox.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: no related issue
About
According to the binvox specification the scale stored in binvox should be what the normalized voxel coordinates (in the interval [0, 1]) should be scaled by.
This is also how the scale is interpreted in this Python binvox implementation.
How Has This Been Tested?
Tested by using other implementations to read the resulting
.binvoxfiles.