-
Notifications
You must be signed in to change notification settings - Fork 60
Http framework integration refactor #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
axelsrz
merged 8 commits into
main
from
users/axelsrz/http-framework-integration-refactor
Nov 20, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
318a0ce
Http framework integration refactor WIP
axelsrz 8a7cd56
Revert "Http framework integration refactor WIP"
axelsrz e0fcd0e
HTTP Refactor WIP: merge conflicts pending
axelsrz 4dde4c7
Resolving merge conflicts
axelsrz a9809b5
Cleaning unused references
axelsrz 688e2da
Fix: minor comments
axelsrz 0d55c4d
Fix: minor comments
axelsrz 2343da4
Merge branch 'main' into users/axelsrz/http-framework-integration-ref…
axelsrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 65 additions & 116 deletions
181
...ft-agents-hosting-aiohttp/microsoft_agents/hosting/aiohttp/channel_service_route_table.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,194 +1,143 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
| import json | ||
| from typing import List, Union, Type | ||
|
|
||
| from aiohttp.web import RouteTableDef, Request, Response | ||
|
|
||
| from microsoft_agents.activity import ( | ||
| AgentsModel, | ||
| Activity, | ||
| AttachmentData, | ||
| ConversationParameters, | ||
| Transcript, | ||
| ) | ||
| from microsoft_agents.hosting.core import ChannelApiHandlerProtocol | ||
| from microsoft_agents.hosting.core.http import ChannelServiceRoutes | ||
|
|
||
|
|
||
| async def deserialize_from_body( | ||
| request: Request, target_model: Type[AgentsModel] | ||
| ) -> Activity: | ||
| if "application/json" in request.headers["Content-Type"]: | ||
| body = await request.json() | ||
| else: | ||
| return Response(status=415) | ||
| class AiohttpRequestAdapter: | ||
| """Adapter for aiohttp requests to use with ChannelServiceRoutes.""" | ||
|
|
||
| return target_model.model_validate(body) | ||
| def __init__(self, request: Request): | ||
| self._request = request | ||
|
|
||
| @property | ||
| def method(self) -> str: | ||
| return self._request.method | ||
|
|
||
| def get_serialized_response( | ||
| model_or_list: Union[AgentsModel, List[AgentsModel]], | ||
| ) -> Response: | ||
| if isinstance(model_or_list, AgentsModel): | ||
| json_obj = model_or_list.model_dump( | ||
| mode="json", exclude_unset=True, by_alias=True | ||
| ) | ||
| else: | ||
| json_obj = [ | ||
| model.model_dump(mode="json", exclude_unset=True, by_alias=True) | ||
| for model in model_or_list | ||
| ] | ||
| @property | ||
| def headers(self): | ||
| return self._request.headers | ||
|
|
||
| async def json(self): | ||
| return await self._request.json() | ||
|
|
||
| def get_claims_identity(self): | ||
| return self._request.get("claims_identity") | ||
|
|
||
| return Response(body=json.dumps(json_obj), content_type="application/json") | ||
| def get_path_param(self, name: str) -> str: | ||
| return self._request.match_info[name] | ||
|
|
||
|
|
||
| def channel_service_route_table( | ||
| handler: ChannelApiHandlerProtocol, base_url: str = "" | ||
| ) -> RouteTableDef: | ||
| # pylint: disable=unused-variable | ||
| """Create aiohttp route table for Channel Service API. | ||
|
|
||
| Args: | ||
| handler: The handler that implements the Channel API protocol. | ||
| base_url: Optional base URL prefix for all routes. | ||
|
|
||
| Returns: | ||
| RouteTableDef with all channel service routes. | ||
| """ | ||
| routes = RouteTableDef() | ||
| service_routes = ChannelServiceRoutes(handler, base_url) | ||
|
|
||
| def json_response(data: dict) -> Response: | ||
| return Response(body=json.dumps(data), content_type="application/json") | ||
|
|
||
| @routes.post(base_url + "/v3/conversations/{conversation_id}/activities") | ||
| async def send_to_conversation(request: Request): | ||
| activity = await deserialize_from_body(request, Activity) | ||
| result = await handler.on_send_to_conversation( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| activity, | ||
| result = await service_routes.send_to_conversation( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.post( | ||
| base_url + "/v3/conversations/{conversation_id}/activities/{activity_id}" | ||
| ) | ||
| async def reply_to_activity(request: Request): | ||
| activity = await deserialize_from_body(request, Activity) | ||
| result = await handler.on_reply_to_activity( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| request.match_info["activity_id"], | ||
| activity, | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| result = await service_routes.reply_to_activity(AiohttpRequestAdapter(request)) | ||
| return json_response(result) | ||
|
|
||
| @routes.put( | ||
| base_url + "/v3/conversations/{conversation_id}/activities/{activity_id}" | ||
| ) | ||
| async def update_activity(request: Request): | ||
| activity = await deserialize_from_body(request, Activity) | ||
| result = await handler.on_update_activity( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| request.match_info["activity_id"], | ||
| activity, | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| result = await service_routes.update_activity(AiohttpRequestAdapter(request)) | ||
| return json_response(result) | ||
|
|
||
| @routes.delete( | ||
| base_url + "/v3/conversations/{conversation_id}/activities/{activity_id}" | ||
| ) | ||
| async def delete_activity(request: Request): | ||
| await handler.on_delete_activity( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| request.match_info["activity_id"], | ||
| ) | ||
|
|
||
| await service_routes.delete_activity(AiohttpRequestAdapter(request)) | ||
| return Response() | ||
|
|
||
| @routes.get( | ||
| base_url | ||
| + "/v3/conversations/{conversation_id}/activities/{activity_id}/members" | ||
| ) | ||
| async def get_activity_members(request: Request): | ||
| result = await handler.on_get_activity_members( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| request.match_info["activity_id"], | ||
| result = await service_routes.get_activity_members( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.post(base_url + "/") | ||
| async def create_conversation(request: Request): | ||
| conversation_parameters = deserialize_from_body(request, ConversationParameters) | ||
| result = await handler.on_create_conversation( | ||
| request.get("claims_identity"), conversation_parameters | ||
| result = await service_routes.create_conversation( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.get(base_url + "/") | ||
| async def get_conversation(request: Request): | ||
| # TODO: continuation token? conversation_id? | ||
| result = await handler.on_get_conversations( | ||
| request.get("claims_identity"), None | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| result = await service_routes.get_conversations(AiohttpRequestAdapter(request)) | ||
| return json_response(result) | ||
|
|
||
| @routes.get(base_url + "/v3/conversations/{conversation_id}/members") | ||
| async def get_conversation_members(request: Request): | ||
| result = await handler.on_get_conversation_members( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| result = await service_routes.get_conversation_members( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.get(base_url + "/v3/conversations/{conversation_id}/members/{member_id}") | ||
| async def get_conversation_member(request: Request): | ||
| result = await handler.on_get_conversation_member( | ||
| request.get("claims_identity"), | ||
| request.match_info["member_id"], | ||
| request.match_info["conversation_id"], | ||
| result = await service_routes.get_conversation_member( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.get(base_url + "/v3/conversations/{conversation_id}/pagedmembers") | ||
| async def get_conversation_paged_members(request: Request): | ||
| # TODO: continuation token? page size? | ||
| result = await handler.on_get_conversation_paged_members( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| result = await service_routes.get_conversation_paged_members( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.delete(base_url + "/v3/conversations/{conversation_id}/members/{member_id}") | ||
| async def delete_conversation_member(request: Request): | ||
| result = await handler.on_delete_conversation_member( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| request.match_info["member_id"], | ||
| result = await service_routes.delete_conversation_member( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.post(base_url + "/v3/conversations/{conversation_id}/activities/history") | ||
| async def send_conversation_history(request: Request): | ||
| transcript = deserialize_from_body(request, Transcript) | ||
| result = await handler.on_send_conversation_history( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| transcript, | ||
| result = await service_routes.send_conversation_history( | ||
| AiohttpRequestAdapter(request) | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| return json_response(result) | ||
|
|
||
| @routes.post(base_url + "/v3/conversations/{conversation_id}/attachments") | ||
| async def upload_attachment(request: Request): | ||
| attachment_data = deserialize_from_body(request, AttachmentData) | ||
| result = await handler.on_upload_attachment( | ||
| request.get("claims_identity"), | ||
| request.match_info["conversation_id"], | ||
| attachment_data, | ||
| ) | ||
|
|
||
| return get_serialized_response(result) | ||
| result = await service_routes.upload_attachment(AiohttpRequestAdapter(request)) | ||
| return json_response(result) | ||
|
|
||
| return routes | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.