Set owners@odata.bind during blueprint creation #164
Merged
+129
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set owners@odata.bind during blueprint creation to address Entra bug preventing post-creation owner assignment. Remove post-creation owner add logic and replace with read-only owner validation (IsApplicationOwnerAsync). Update logging, user guidance, and tests to reflect new behavior. Improve Azure CLI login messaging.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the application owner management approach for Agent Blueprint creation. Instead of using a 2-call pattern (create blueprint, then add owner), it now sets owners during blueprint creation using the owners@odata.bind field. The AddApplicationOwnerAsync method is renamed to IsApplicationOwnerAsync to reflect its new read-only validation purpose.
Changes:
- Refactored
AddApplicationOwnerAsynctoIsApplicationOwnerAsyncfor read-only owner validation - Added
owners@odata.bindfield during blueprint creation to set owners upfront - Enhanced Azure CLI login messaging with better user guidance
- Updated all tests to reflect the new read-only behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GraphApiServiceIsApplicationOwnerTests.cs | Renamed test class and updated all test methods to verify read-only owner checking behavior instead of owner addition logic |
| GraphApiService.cs | Renamed method from AddApplicationOwnerAsync to IsApplicationOwnerAsync, removed POST logic, kept only GET/validation logic, and improved login messaging |
| BlueprintSubcommand.cs | Added owners@odata.bind field during blueprint creation, replaced owner addition with read-only validation for new blueprints, and added comprehensive user guidance for manual owner management |
| InfrastructureSubcommand.cs | Enhanced Azure CLI login message to guide users about browser window location |
Comments suppressed due to low confidence (2)
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/GraphApiServiceIsApplicationOwnerTests.cs:230
- Disposable 'HttpResponseMessage' is created but not disposed.
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/GraphApiServiceIsApplicationOwnerTests.cs:254 - Disposable 'HttpResponseMessage' is created but not disposed.
mengyimicro
approved these changes
Jan 20, 2026
joratz
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set owners@odata.bind during blueprint creation to address Entra bug preventing post-creation owner assignment. Remove post-creation owner add logic and replace with read-only owner validation (IsApplicationOwnerAsync). Update logging, user guidance, and tests to reflect new behavior. Improve Azure CLI login messaging.
Fixes #159