Skip to content

Sanitize JSON output before parsing in ClientAppValidator #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sellakumaran merged 1 commit into from
Jan 9, 2026
Merged

Sanitize JSON output before parsing in ClientAppValidator #147

sellakumaran merged 1 commit into from
Jan 9, 2026

Conversation

@rahuldevikar761
Copy link
Collaborator

@rahuldevikar761 rahuldevikar761 commented Jan 8, 2026 •
edited
Loading

image

@rahuldevikar761 rahuldevikar761 requested a review from a team as a code owner January 8, 2026 21:55
Copilot AI review requested due to automatic review settings January 8, 2026 21:55
@rahuldevikar761 rahuldevikar761 requested a review from a team as a code owner January 8, 2026 21:55
Copilot AI reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds JSON output sanitization before parsing Azure CLI responses in the ClientAppValidator service. The change addresses potential issues where Azure CLI on Windows can output control characters (like form feed) and warning messages that interfere with JSON parsing.

  • Introduces JsonDeserializationHelper.CleanAzureCliJsonOutput() call before all JsonNode.Parse() operations
  • Updates 7 locations where Azure CLI JSON output is parsed
  • Adds import for the Services.Helpers namespace

@sellakumaran sellakumaran merged commit f3aa6b4 into main Jan 9, 2026
11 checks passed
@sellakumaran sellakumaran deleted the users/radevika/sanitizeClientAppValidator branch January 9, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mengyimicro mengyimicro mengyimicro approved these changes

@sellakumaran sellakumaran sellakumaran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rahuldevikar761 @mengyimicro @sellakumaran