Skip to content

XRechnung - FormatDecimal with Two Decimal Places#29846

Open
pri-kise wants to merge 2 commits intomicrosoft:mainfrom
pri-kise:29717-xrechnung-format-amount-optional-with-all-two-decimals
Open

XRechnung - FormatDecimal with Two Decimal Places#29846
pri-kise wants to merge 2 commits intomicrosoft:mainfrom
pri-kise:29717-xrechnung-format-amount-optional-with-all-two-decimals

Conversation

@pri-kise
Copy link
Contributor

@pri-kise pri-kise commented Mar 19, 2026

Summary

Provide an intergration Event in XRechnung Export to always include two decimals for Amount fields

Work Item(s)

Fixes #29717

Fixes AB#626471

@github-actions
Copy link
Contributor

Issue #29717 is not valid. Please make sure you link an issue that exists, is open and is approved.

@pri-kise pri-kise marked this pull request as ready for review March 20, 2026 08:00
@pri-kise pri-kise requested a review from a team as a code owner March 20, 2026 08:00
@pri-kise pri-kise requested a review from Aleyenda March 20, 2026 08:00
@miljance
Copy link
Contributor

@pri-kise
Overall, I like the direction of this change. That said, I think it may be incomplete.
The flag name AlwaysIncludeTwoDecimalPlacesForAmountFields makes it clear this only applies to amount fields - which is fine. My concern is a potential inconsistency: while an amount would now correctly render as 5,00, the Unit Price could still render as 5, since it's not covered by this flag. Do you see that as a problem or you that is not perceived as a problem?

@pri-kise
Copy link
Contributor Author

@pri-kise
Overall, I like the direction of this change. That said, I think it may be incomplete.
The flag name AlwaysIncludeTwoDecimalPlacesForAmountFields makes it clear this only applies to amount fields - which is fine. My concern is a potential inconsistency: while an amount would now correctly render as 5,00, the Unit Price could still render as 5, since it's not covered by this flag. Do you see that as a problem or you that is not perceived as a problem?

That's good input. I'll discuss this with my colleague

@JesperSchulz JesperSchulz added processing-PR The PR is currently being reviewed linked Issue is linked to a Azure Boards work item Finance GitHub request for Finance area and removed processing-PR The PR is currently being reviewed labels Mar 23, 2026
@microsoft microsoft deleted a comment from github-actions bot Mar 23, 2026
@AndersLarsenMicrosoft AndersLarsenMicrosoft self-assigned this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DE] [Event Request] E-Documents for Germany - Export XRechnung - OnAfterFormatDecimal, OnAfterFormatFourDecimal

4 participants