Skip to content

Conversation

@miljance
Copy link
Contributor

@miljance miljance commented Nov 26, 2025

Summary

Refactored InsertApplicableHeaderTradeAgreement :

  • Changed the method signature from accepting CustomerNo and YourReference parameters to accepting a RecordVariant parameter
  • Added support for both Sales Invoice Header and Sales Cr.Memo Header using RecordRef and case statement
  • Extracted all customer/header fields (Customer No., Name, Address, Post Code, City, Country Code, VAT Reg No., Your Reference, Contact, Email, Phone Number) directly from the header record instead of loading the Customer record separately
  • Added email addresses for both Seller (Company) and Buyer (Customer) to the XML output using URIUniversalCommunication elements with schemeID='EM'
  • Updated method calls to pass the header record instead of individual parameters

Updated test support:

  • Added E-Mail field validation when creating test customers
  • Added verification for Seller email in VerifySellerData
  • Added verification for Buyer email in VerifyBuyerData methods
  • Set "Buyer Reference Mandatory" to true when configuring the E-Document Service

Summary: Corrected the implementation to include email addresses in the ZUGFeRD XML output for both the seller (company) and buyer (customer), making the electronic documents more complete and compliant with ZUGFeRD format requirements.

Work Item(s)

Fixes #29420
AB#614338

@miljance miljance requested a review from a team as a code owner November 26, 2025 14:49
@miljance miljance requested a review from romansauber November 26, 2025 14:49
djukicmilica
djukicmilica previously approved these changes Nov 26, 2025
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Nov 26, 2025
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Dec 1, 2025
@miljance miljance requested a review from duichwer December 1, 2025 16:27
@miljance miljance force-pushed the ZUGFeRDIncludeEmailInXML branch from 973bdb4 to 74f919f Compare December 2, 2025 08:46
@miljance miljance changed the title Exporting Email and Data from Header xRechnung: Exporting Email and Data from Header Dec 2, 2025
@JesperSchulz JesperSchulz self-assigned this Dec 5, 2025
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz
Copy link
Contributor

This PR has been merged internally. Trying to merge here on GitHub too.

@JesperSchulz JesperSchulz merged commit b3ed27a into microsoft:main Dec 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Customer email is not exported to ZUGFeRD XML

4 participants